Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: fix syncer gtid auto switch from off to on (#1723) #1745

Merged
merged 16 commits into from
Jun 9, 2021
Merged

syncer: fix syncer gtid auto switch from off to on (#1723) #1745

merged 16 commits into from
Jun 9, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1723

What problem does this PR solve?

#1586 part 1

What is changed and how it works?

Add auto adjust gtid before we start a task.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 3, 2021
Merged
@ti-chi-bot ti-chi-bot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated require-LGT1 for small PR, LGT1 is enough size/XXL status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick-for-release-2.0 labels Jun 3, 2021
GMHDBJD
GMHDBJD approved these changes Jun 7, 2021
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Jun 7, 2021
@lance6716
Copy link
Collaborator

waiting CI upgrading?

@lance6716
Copy link
Collaborator

dont know why master PR removed some lines in go.sum and passed CI, but this PR can't

@lance6716
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 39c88b9

@ti-chi-bot ti-chi-bot merged commit 5269b0a into pingcap:release-2.0 Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees

@lichunzhu lichunzhu

Labels
needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated require-LGT1 for small PR, LGT1 is enough size/XXL status/can-merge status/LGT1 One reviewer already commented LGTM status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick-for-release-2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @lance6716 @GMHDBJD @lichunzhu