-
Notifications
You must be signed in to change notification settings - Fork 188
dmctl: fix dmctl command to improve its usability (#1750) #1771
dmctl: fix dmctl command to improve its usability (#1750) #1771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: f92af34
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #1750
What problem does this PR solve?
Previous dmctl has to put
--master-addr
in the front. What's more, we hack many usage which is not standard usage of cobra commands.What is changed and how it works?
--master-addr
can be put any where.--decrypt/encrypt
as hidden. Addencrypt/decrypt
commands.Check List
Tests
Related changes