This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
pkg/retry: add some retryable error #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangXiangUSTC
added
priority/normal
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
================================================
- Coverage 59.9383% 59.9246% -0.0138%
================================================
Files 130 130
Lines 14595 14595
================================================
- Hits 8748 8746 -2
- Misses 5012 5013 +1
- Partials 835 836 +1 |
|
@WangXiangUSTC Add any description about these newly added error codes? |
amyangfei
reviewed
Aug 29, 2019
|
@csuzhangxc description added |
|
@amyangfei this error occurred when some one kill the query |
csuzhangxc
added
status/LGT1
maybe a query/execute longer than timeout will cause this error in our use scenario, otherwise our db op may not cancel a query (except for context canceled, then retry is not needed yet) |
amyangfei
added
status/LGT2
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
some tidb error can be resolved by retry, add some retryable error type
What is changed and how it works?
add some error
ErrQueryInterrupted: query execution was interrupted by user
ErrWriteConflictInTiDB: commit meets an write conflict error
ErrWriteConflict: similar with ErrWriteConflictInTiDB
ErrTableLocked: the table was locked by other session, can retry success when other session release the lock.