This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
worker: fix potential panic when restoring subtask from meta (#305) #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #305 to release-1.0
What problem does this PR solve?
What is changed and how it works?
before this PR, we have the following order in worker.go:
InitConditionHub
registersWorker
instancesrestoreSubTask
restores subtasks from metaw.ctx, w.cancel = context.WithCancel(context.Background())
initsw.ctx
andw.cancel
but when restoring subtasks from meta,
w.ctx
may be used, thennil
pointer will be accessed and panicked.in this PR, we make sure have the following order:
w.ctx, w.cancel = context.WithCancel(context.Background())
initsw.ctx
andw.cancel
InitConditionHub
registersWorker
instancesrestoreSubTask
restores subtasks from metaCheck List
Tests
Related changes