This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
mydumper: generate tables needed to dump for mydumper automatically (#310) #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…check whether we should generate tables args or not
sre-bot
added
priority/normal
|
please fix this cherry pick @lichunzhu |
Codecov Report
@@ Coverage Diff @@
## release-1.0 #326 +/- ##
==============================================
Coverage 59.9455% 59.9455%
==============================================
Files 135 135
Lines 15047 15047
==============================================
Hits 9020 9020
Misses 5151 5151
Partials 876 876 |
IANTHEREAL
reviewed
Oct 19, 2019
| @@ -161,7 +162,8 @@ func (t *testServer) TestTaskAutoResume(c *C) { | |||
| // start task | |||
| cli := t.createClient(c, fmt.Sprintf("127.0.0.1:%d", port)) | |||
| subtaskCfgBytes, err := ioutil.ReadFile("./subtask.toml") | |||
| _, err = cli.StartSubTask(context.Background(), &pb.StartSubTaskRequest{Task: string(subtaskCfgBytes)}) | |||
| // strings.Replace is used here to uncomment extra-args to avoid mydumper connecting to DB and generating arg --tables-list which will cause failure | |||
There was a problem hiding this comment.
is it the only way to handle this problem? it's tricky
There was a problem hiding this comment.
Yes, I admit that. Perhaps we can add failpoint to solve this problem?
WangXiangUSTC
added
status/LGT2
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
csuzhangxc
added
already-update-release-note
csuzhangxc
added
already-update-docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #310 to release-1.0
What problem does this PR solve?
Now users need to add
extra-argsformydumperto help it decide tables needed to dump. When the situations are very complicated it's very hard for users to do that. This PR aims to generate the tables needed to be dumped automatically so that we can simplify the configuration process.What is changed and how it works?
Generate mydumper
extra-argsthrough black-white list and router rules when it is empty. Before start mydumper will connect toDBto fetch all the tables from database, filter useful tables and generateextra-argsin--tables-list db1.tb1,db2.tb2..format.A unit-test is added to test whether it can generate right args when
extra-argsis empty. For integration_tests except "start_task" I expurge theextra-argsto test whether it can run correctly.Check List
Tests
Related changes