Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

checker: increase total timeout to 30m; set readTimeout for DB check operation to 30s (#315) #327

Merged
merged 4 commits into from
Oct 21, 2019
Merged

checker: increase total timeout to 30m; set readTimeout for DB check operation to 30s (#315) #327

merged 4 commits into from
Oct 21, 2019

Conversation

sre-bot
Copy link

@sre-bot sre-bot commented Oct 21, 2019

cherry-pick #315 to release-1.0

What problem does this PR solve?

If a mass of tables in one task, the check operation may not be complete in 1 minute.

What is changed and how it works?

  1. increase the total check timeout to 30 minutes
  2. set readTimeout for DB operation to 30s

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

@sre-bot sre-bot mentioned this pull request Oct 21, 2019
Merged
@sre-bot sre-bot added priority/normal Minor change, requires approval from ≥1 primary reviewer priority/release-blocker This PR blocks a release. Please review it ASAP. type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Oct 21, 2019
@WangXiangUSTC
Copy link
Contributor

LGTM

@WangXiangUSTC WangXiangUSTC added the status/LGT1 One reviewer already commented LGTM label Oct 21, 2019
lichunzhu
lichunzhu approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu lichunzhu added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Oct 21, 2019
@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #327 into release-1.0 will decrease coverage by 0.0373%.
The diff coverage is 0%.

@@                Coverage Diff                 @@
##           release-1.0      #327        +/-   ##
==================================================
- Coverage      59.9614%   59.924%   -0.0374%     
==================================================
  Files              135       135                
  Lines            15043     15014        -29     
==================================================
- Hits              9020      8997        -23     
+ Misses            5147      5145         -2     
+ Partials           876       872         -4

@csuzhangxc csuzhangxc merged commit cf3623b into pingcap:release-1.0 Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

@WangXiangUSTC WangXiangUSTC Awaiting requested review from WangXiangUSTC

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer priority/release-blocker This PR blocks a release. Please review it ASAP. status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @WangXiangUSTC @lichunzhu @csuzhangxc