Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

worker: generate index flavor automatically by querying version info from DB (#323) #328

Merged
merged 1 commit into from
Oct 22, 2019
Merged

worker: generate index flavor automatically by querying version info from DB (#323) #328

merged 1 commit into from
Oct 22, 2019

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Oct 21, 2019 •
edited
Loading

cherry-pick #323 to release-1.0

What problem does this PR solve?

Now, we need to set flavor for DM-worker manually, but it may be set incorrectly.

What is changed and how it works?

use dbutil.ShowVersion and check.IsMariaDB from tidb-tools to detect upstream MySQL/MariaDB server type and set flavor automatically.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@lichunzhu lichunzhu added priority/normal Minor change, requires approval from ≥1 primary reviewer needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) priority/release-blocker This PR blocks a release. Please review it ASAP. needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Oct 21, 2019
@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release-1.0@61ad0ca). Click here to learn what that means.
The diff coverage is 53.125%.

@@               Coverage Diff                @@
##             release-1.0       #328   +/-   ##
================================================
  Coverage               ?   59.9111%           
================================================
  Files                  ?        135           
  Lines                  ?      15079           
  Branches               ?          0           
================================================
  Hits                   ?       9034           
  Misses                 ?       5166           
  Partials               ?        879

csuzhangxc
csuzhangxc reviewed Oct 21, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Oct 21, 2019
@csuzhangxc
Copy link
Member

@WangXiangUSTC PTAL

WangXiangUSTC
WangXiangUSTC approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Oct 21, 2019
@csuzhangxc csuzhangxc merged commit bad74fa into pingcap:release-1.0 Oct 22, 2019
@lichunzhu lichunzhu deleted the czli/release-1.0/dm-worker/simplifyFlavor branch October 22, 2019 02:17
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Nov 1, 2019
@csuzhangxc csuzhangxc added already-update-docs The docs related to this PR already updated. Add this label once the docs are updated and removed needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
already-update-docs The docs related to this PR already updated. Add this label once the docs are updated already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer priority/release-blocker This PR blocks a release. Please review it ASAP. status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lichunzhu @csuzhangxc @WangXiangUSTC