This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
dmctl: simplify default query-status output (#334) #340
Merged
csuzhangxc
merged 14 commits into
pingcap:release-1.0
from
sre-bot:release-1.0-3870d5dd407c
Oct 29, 2019
Merged
dmctl: simplify default query-status output (#334) #340
csuzhangxc
merged 14 commits into
pingcap:release-1.0
from
sre-bot:release-1.0-3870d5dd407c
Oct 29, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sre-bot
added
priority/normal
Minor change, requires approval from ≥1 primary reviewer
needs-update-docs
Should update docs after this PR is merged. Remove this label once the docs are updated
needs-update-release-note
This PR should be added into release notes. Remove this label once the release notes are updated
type/cherry-pick
This PR is just a cherry-pick (backport)
labels
Oct 29, 2019
Codecov Report
@@ Coverage Diff @@
## release-1.0 #340 +/- ##
================================================
Coverage ? 57.5979%
================================================
Files ? 158
Lines ? 15978
Branches ? 0
================================================
Hits ? 9203
Misses ? 5876
Partials ? 899 |
csuzhangxc
reviewed
Oct 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
amyangfei
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
csuzhangxc
added
status/LGT2
Two reviewers already commented LGTM, ready for merge
and removed
status/LGT1
One reviewer already commented LGTM
labels
Oct 29, 2019
csuzhangxc
removed
the
needs-update-release-note
This PR should be added into release notes. Remove this label once the release notes are updated
label
Nov 1, 2019
csuzhangxc
added
the
already-update-release-note
The release note is updated. Add this label once the release note is updated
label
Nov 1, 2019
csuzhangxc
added
already-update-docs
The docs related to this PR already updated. Add this label once the docs are updated
and removed
needs-update-docs
Should update docs after this PR is merged. Remove this label once the docs are updated
labels
Mar 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
already-update-docs
The docs related to this PR already updated. Add this label once the docs are updated
already-update-release-note
The release note is updated. Add this label once the release note is updated
priority/normal
Minor change, requires approval from ≥1 primary reviewer
status/LGT2
Two reviewers already commented LGTM, ready for merge
type/cherry-pick
This PR is just a cherry-pick (backport)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #334 to release-1.0
What problem does this PR solve?
Current
query-status
command without any args in dmctl will print a lot of information but users are concerned about a little of them.What is changed and how it works?
This PR generates and returns a simple task-list when users don't specify any arg. The proto files are not changed. This PR only generates task-list info in dmctl and modifies the output after receiving full dm-workers' info from dm-master.
The output will be like this format:
The status of a task is based on its subtasks. The definition is listed as follows:
Check List
Tests
Related changes