This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
checker/:ignore unnecessary privilege for different task modes (#372) #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sre-bot
added
priority/normal
|
/run-all-tests tidb=release-3.0 |
|
/run-all-tests tidb=release-3.0 |
1 similar comment
|
/run-all-tests tidb=release-3.0 |
|
/run-unit-tests tidb=release-3.0 |
Codecov Report
@@ Coverage Diff @@
## release-1.0 #374 +/- ##
================================================
Coverage ? 57.3472%
================================================
Files ? 158
Lines ? 16074
Branches ? 0
================================================
Hits ? 9218
Misses ? 5949
Partials ? 907 |
|
LGTM |
WangXiangUSTC
added
status/LGT2
WangXiangUSTC
approved these changes
Nov 26, 2019
csuzhangxc
removed
the
needs-update-release-note
csuzhangxc
added
the
already-update-release-note
csuzhangxc
added
already-update-docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #372 to release-1.0
What problem does this PR solve?
Now we check all the privileges when we start dm which is unreasonable. For task mode full we don't need replication privilege while for task mode increment we don't need dump privilege.
What is changed and how it works?
Add unnecessary privilege check to ignore checking items for different task modes.
Check List
Tests
Related changes