This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
config/task: add check for duplicate config items (#380) #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sre-bot
added
priority/normal
|
/run-all-tests tidb=release-3.0 |
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## release-1.0 #385 +/- ##
==============================================
Coverage 57.2215% 57.2215%
==============================================
Files 159 159
Lines 16153 16153
==============================================
Hits 9243 9243
Misses 6003 6003
Partials 907 907 |
csuzhangxc
added
status/LGT2
csuzhangxc
added
already-update-release-note
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #380 to release-1.0
What problem does this PR solve?
The user may add duplicate route-rules or filter-rules by mistake which will cause failure while building router or event-filter.
e.g.: route-rules: ["route-rule-1", "route-rule-1"]
What is changed and how it works?
Add check in
TaskConfig.adjustand returns error if route-rules/filter-rules are duplicate.Check List
Tests
Related changes