Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

pkg: support to sync alter database DDL (#388) #389

Merged
merged 1 commit into from
Dec 2, 2019
Merged

pkg: support to sync alter database DDL (#388) #389

merged 1 commit into from
Dec 2, 2019

Conversation

sre-bot
Copy link

@sre-bot sre-bot commented Dec 2, 2019

cherry-pick #388 to release-1.0

What problem does this PR solve?

TiDB supports ALTER DATABASE now, remove it in DM default filter

What is changed and how it works?

remove alter database from builtInSkipDDLs

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@sre-bot sre-bot mentioned this pull request Dec 2, 2019
Merged
@sre-bot sre-bot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated type/cherry-pick This PR is just a cherry-pick (backport) type/enhancement Performance improvement or refactoring labels Dec 2, 2019
@csuzhangxc
Copy link
Member

/run-all-tests tidb=release-3.0

csuzhangxc
csuzhangxc approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added the status/LGT1 One reviewer already commented LGTM label Dec 2, 2019
@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #389 into release-1.0 will decrease coverage by 0.0247%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-1.0       #389        +/-   ##
===================================================
- Coverage      57.2471%   57.2224%   -0.0248%     
===================================================
  Files              159        159                
  Lines            16158      16158                
===================================================
- Hits              9250       9246         -4     
- Misses            6002       6004         +2     
- Partials           906        908         +2

WangXiangUSTC
WangXiangUSTC approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Dec 2, 2019
@csuzhangxc csuzhangxc merged commit edad4c2 into pingcap:release-1.0 Dec 2, 2019
@ericsyh ericsyh added this to the v1.0.3 milestone Dec 3, 2019
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
already-update-release-note The release note is updated. Add this label once the release note is updated status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport) type/enhancement Performance improvement or refactoring
Projects
None yet
Milestone
v1.0.3
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @csuzhangxc @WangXiangUSTC @ericsyh @amyangfei