Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: don't clear online ddl if execute ddl failed(#449) #465

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

WangXiangUSTC
Copy link
Contributor

What problem does this PR solve?

when execute ddl failed, ignore clean online ddl information

What is changed and how it works?

cherry-pick from #449 and resolve conflicts

Related changes

  • Need to be included in the release note

@WangXiangUSTC WangXiangUSTC added priority/important Major change, requires approval from ≥2 primary reviewers status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix labels Feb 3, 2020
@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests tidb=release-3.0

@WangXiangUSTC WangXiangUSTC added the type/cherry-pick This PR is just a cherry-pick (backport) label Feb 3, 2020
@WangXiangUSTC
Copy link
Contributor Author

@lichunzhu @csuzhangxc PTAL

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #465 into release-1.0 will decrease coverage by 0.012%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-1.0       #465        +/-   ##
===================================================
- Coverage      57.1136%   57.1016%   -0.0121%     
===================================================
  Files              161        161                
  Lines            16637      16637                
===================================================
- Hits              9502       9500         -2     
- Misses            6198       6199         +1     
- Partials           937        938         +1

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu lichunzhu added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Feb 4, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Feb 4, 2020
@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests tidb=release-3.0

@WangXiangUSTC WangXiangUSTC merged commit 23665f1 into release-1.0 Feb 4, 2020
@WangXiangUSTC WangXiangUSTC deleted the xiang/cherry-pick branch February 4, 2020 09:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/important Major change, requires approval from ≥2 primary reviewers status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants