This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
syncer: don't clear online ddl if execute ddl failed(#449) #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangXiangUSTC
added
priority/important
Major change, requires approval from ≥2 primary reviewers
status/PTAL
This PR is ready for review. Add this label back after committing new changes
type/bug-fix
Bug fix
labels
Feb 3, 2020
/run-all-tests tidb=release-3.0 |
@lichunzhu @csuzhangxc PTAL |
Codecov Report
@@ Coverage Diff @@
## release-1.0 #465 +/- ##
===================================================
- Coverage 57.1136% 57.1016% -0.0121%
===================================================
Files 161 161
Lines 16637 16637
===================================================
- Hits 9502 9500 -2
- Misses 6198 6199 +1
- Partials 937 938 +1 |
lichunzhu
reviewed
Feb 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lichunzhu
added
status/LGT1
One reviewer already commented LGTM
and removed
status/PTAL
This PR is ready for review. Add this label back after committing new changes
labels
Feb 4, 2020
csuzhangxc
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
csuzhangxc
added
status/LGT2
Two reviewers already commented LGTM, ready for merge
and removed
status/LGT1
One reviewer already commented LGTM
labels
Feb 4, 2020
/run-all-tests tidb=release-3.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
priority/important
Major change, requires approval from ≥2 primary reviewers
status/LGT2
Two reviewers already commented LGTM, ready for merge
type/bug-fix
Bug fix
type/cherry-pick
This PR is just a cherry-pick (backport)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
when execute ddl failed, ignore clean online ddl information
What is changed and how it works?
cherry-pick from #449 and resolve conflicts
Related changes