Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

Dm portal speical week and i18n #480

Merged
merged 2 commits into from
Feb 14, 2020

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Feb 14, 2020

What problem does this PR solve?

Cherry-pick PR #417 and #476

* portal: rename dm-fe folder to frontend

* portal: udpate frontend README

* portal: add option to control whether auto sync with upstream newly added schemas or tables

* portal: validate the task name

* portal: differ the undo and reset action more clearly
@WangXiangUSTC
Copy link
Contributor

/run-all-tests tidb=release-3.0

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (release-1.0@23665f1). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-1.0       #480   +/-   ##
================================================
  Coverage               ?   57.0896%           
================================================
  Files                  ?        161           
  Lines                  ?      16637           
  Branches               ?          0           
================================================
  Hits                   ?       9498           
  Misses                 ?       6200           
  Partials               ?        939

@WangXiangUSTC
Copy link
Contributor

LGTM

@WangXiangUSTC WangXiangUSTC added the status/LGT1 One reviewer already commented LGTM label Feb 14, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Feb 14, 2020
@csuzhangxc csuzhangxc merged commit 8683ec7 into release-1.0 Feb 14, 2020
@csuzhangxc csuzhangxc deleted the dm-portal-speical-week-and-i18n branch February 14, 2020 06:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants