This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
dm-worker/: refine query error #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests tidb=release-3.0 |
|
/run-all-tests tidb=release-3.0 |
| case pb.UnitType_Sync: | ||
| stError.Error = &pb.SubTaskError_Sync{Sync: us.(*pb.SyncError)} | ||
| if cu != nil { | ||
| // oneof error |
There was a problem hiding this comment.
Suggested change
| // oneof error | |
| // one of error |
|
LGTM |
csuzhangxc
added
status/LGT2
lichunzhu
added a commit
that referenced
this pull request
Mar 10, 2020
lichunzhu
added a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
* fix worker query error bug
lichunzhu
added a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
* fix worker query error bug
lichunzhu
added a commit
to lichunzhu/dm
that referenced
this pull request
Apr 7, 2020
* fix worker query error bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#509
Current DM-worker may have no
currUnitwhen some error occurs duringInit, which will cause nil-pointer error while usingworker.QueryError.What is changed and how it works?
Avoid query
currUnit.ErrorwhencurrUnitis nil. Useresult.Errorsas Error whencurrUnitis nil.Check List
Tests
Related changes