Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: improve performance #606

Merged
merged 9 commits into from
Apr 17, 2020
Merged

*: improve performance #606

merged 9 commits into from
Apr 17, 2020

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Apr 14, 2020 •
edited
Loading

What problem does this PR solve?

improve performance as we did in release-1.0 branch.

What is changed and how it works?

image

image

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to update the documentation
  • Need to be included in the release note

@csuzhangxc csuzhangxc added the status/WIP This PR is still work in progress label Apr 14, 2020
@csuzhangxc
Copy link
Member Author

/run-all-tests

@codecov
Copy link

codecov bot commented Apr 15, 2020 •
edited
Loading

Codecov Report

Merging #606 into master will increase coverage by 0.0331%.
The diff coverage is 82.4120%.

@@               Coverage Diff                @@
##             master       #606        +/-   ##
================================================
+ Coverage   57.8187%   57.8518%   +0.0331%     
================================================
  Files           201        201                
  Lines         20291      20371        +80     
================================================
+ Hits          11732      11785        +53     
- Misses         7431       7455        +24     
- Partials       1128       1131         +3

@csuzhangxc csuzhangxc added needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer type/enhancement Performance improvement or refactoring labels Apr 15, 2020
@csuzhangxc
Copy link
Member Author

@WangXiangUSTC @lichunzhu PTAL

@csuzhangxc csuzhangxc added this to the v2.0.0 beta.1 milestone Apr 15, 2020
lichunzhu
lichunzhu reviewed Apr 16, 2020
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

syncer/dml.go
return strings.Join(values, ",")

var buf strings.Builder
buf.Grow(1024)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we estimate the size? If it's too hard, I think current implemention is also okay.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little complex to estimate the size (it may make the performance worse)

lichunzhu
lichunzhu reviewed Apr 16, 2020
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu lichunzhu added status/LGT1 One reviewer already commented LGTM and removed status/WIP This PR is still work in progress labels Apr 16, 2020
WangXiangUSTC
WangXiangUSTC approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Apr 17, 2020
@csuzhangxc csuzhangxc merged commit c167766 into pingcap:master Apr 17, 2020
@csuzhangxc csuzhangxc deleted the pick-from-1.0 branch April 17, 2020 09:53
@csuzhangxc csuzhangxc mentioned this pull request Apr 30, 2020
Closed
@csuzhangxc csuzhangxc added already-update-docs The docs related to this PR already updated. Add this label once the docs are updated already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lichunzhu lichunzhu lichunzhu left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
already-update-docs The docs related to this PR already updated. Add this label once the docs are updated already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/enhancement Performance improvement or refactoring
Projects
None yet
Milestone
v2.0.0 beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@csuzhangxc @WangXiangUSTC @lichunzhu