This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
syncer/: fix flush checkpoint for ddls for situations that IsSharding is false(#587) #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lichunzhu
added
priority/normal
Codecov Report
@@ Coverage Diff @@
## release-1.0 #624 +/- ##
===================================================
+ Coverage 57.8206% 57.9352% +0.1146%
===================================================
Files 166 166
Lines 16968 17000 +32
===================================================
+ Hits 9811 9849 +38
+ Misses 6207 6196 -11
- Partials 950 955 +5 |
csuzhangxc
reviewed
Apr 24, 2020
csuzhangxc
added
status/LGT1
|
@WangXiangUSTC PTAL |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #587
What problem does this PR solve?
#514
IsShardingis false, table checkpoint which contains schema tracker info was not updated indm_metainstantly. But global checkpoint is updated. If worker fails now, it will cause a mismatch between tracker and global checkpoint.What is changed and how it works?
Update table point when we update global checkpoint.
Check List
Tests
Related changes