Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

test,Makefile: Add more test information in README.md #646

Merged
merged 8 commits into from
May 7, 2020
Merged

test,Makefile: Add more test information in README.md #646

merged 8 commits into from
May 7, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Apr 30, 2020

What problem does this PR solve?

What is changed and how it works?

  • add more test information in tests/README.md
  • copy test file in compatibility_test in Makefile

Check List

Tests

  • No code

lichunzhu
lichunzhu reviewed Apr 30, 2020
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu lichunzhu added the status/LGT1 One reviewer already commented LGTM label Apr 30, 2020
@csuzhangxc csuzhangxc added needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 priority/normal Minor change, requires approval from ≥1 primary reviewer type/qa relate to quality assurance labels Apr 30, 2020
csuzhangxc
csuzhangxc reviewed Apr 30, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

tests/README.md Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 30, 2020 •
edited
Loading

Codecov Report

Merging #646 into master will decrease coverage by 0.0367%.
The diff coverage is 70.0598%.

@@               Coverage Diff                @@
##             master       #646        +/-   ##
================================================
- Coverage   57.7236%   57.6868%   -0.0368%     
================================================
  Files           203        202         -1     
  Lines         20515      20561        +46     
================================================
+ Hits          11842      11861        +19     
- Misses         7526       7551        +25     
- Partials       1147       1149         +2

csuzhangxc
csuzhangxc reviewed Apr 30, 2020
View reviewed changes
tests/README.md Outdated Show resolved Hide resolved
csuzhangxc
csuzhangxc approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Apr 30, 2020
@GMHDBJD GMHDBJD merged commit 5e2356c into pingcap:master May 7, 2020
@GMHDBJD GMHDBJD deleted the addMoreTestInformation branch May 7, 2020 03:20
@sre-bot sre-bot mentioned this pull request May 7, 2020
Merged
@sre-bot
Copy link

sre-bot commented May 7, 2020

cherry pick to release-1.0 in PR #649

@sre-bot sre-bot added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels May 7, 2020
GMHDBJD pushed a commit that referenced this pull request May 7, 2020
@sre-bot
test,Makefile: Add more test information in README.md (#646) (#649)
10ef809
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lichunzhu lichunzhu lichunzhu left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@WangXiangUSTC WangXiangUSTC Awaiting requested review from WangXiangUSTC

Assignees
No one assigned
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/qa relate to quality assurance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GMHDBJD @sre-bot @csuzhangxc @lichunzhu