Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

update tools dependency #664

Merged

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

update tidb-tools to solve table name changing after applyOn black-white-list, details at pingcap/tidb-tools#342

What is changed and how it works?

change tidb-tools to latest version

Check List

Tests

  • Unit test
  • Integration test

@lichunzhu lichunzhu added status/PTAL This PR is ready for review. Add this label back after committing new changes dependencies Pull requests that update a dependency file labels May 14, 2020
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #664 into release-1.0 will increase coverage by 0.0941%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-1.0       #664        +/-   ##
===================================================
+ Coverage      57.8588%   57.9529%   +0.0941%     
===================================================
  Files              166        166                
  Lines            17000      17000                
===================================================
+ Hits              9836       9852        +16     
+ Misses            6208       6193        -15     
+ Partials           956        955         -1     

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels May 14, 2020
@csuzhangxc csuzhangxc added this to the v1.0.6 milestone May 14, 2020
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels May 14, 2020
@lichunzhu lichunzhu merged commit a128158 into pingcap:release-1.0 May 14, 2020
@lichunzhu lichunzhu deleted the release1.0/fixToolsDependency branch May 14, 2020 08:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants