Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

config: support setting session variable (#687) #692

Merged
merged 8 commits into from
May 29, 2020
Merged

config: support setting session variable (#687) #692

merged 8 commits into from
May 29, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented May 29, 2020

What problem does this PR solve?

cherry-pick #687 to release-1.0

What is changed and how it works?

add SessionConfig in TargetDB, set session variables in db.Apply.

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

@codecov
Copy link

codecov bot commented May 29, 2020 •
edited
Loading

Codecov Report

Merging #692 into release-1.0 will increase coverage by 0.0285%.
The diff coverage is 0.0000%.

@@                 Coverage Diff                 @@
##           release-1.0       #692        +/-   ##
===================================================
+ Coverage      57.8408%   57.8693%   +0.0285%     
===================================================
  Files              166        166                
  Lines            16988      16990         +2     
===================================================
+ Hits              9826       9832         +6     
+ Misses            6206       6201         -5     
- Partials           956        957         +1

@GMHDBJD GMHDBJD added status/WIP This PR is still work in progress type/cherry-pick This PR is just a cherry-pick (backport) status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels May 29, 2020
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented May 29, 2020

@lichunzhu @WangXiangUSTC @csuzhangxc PTAL

@GMHDBJD GMHDBJD mentioned this pull request May 29, 2020
Closed
csuzhangxc
csuzhangxc reviewed May 29, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels May 29, 2020
@GMHDBJD GMHDBJD merged commit c29e266 into pingcap:release-1.0 May 29, 2020
@csuzhangxc csuzhangxc added needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated already-update-docs The docs related to this PR already updated. Add this label once the docs are updated and removed needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Jun 15, 2020
@GMHDBJD GMHDBJD deleted the support-session-1.0 branch June 29, 2020 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
already-update-docs The docs related to this PR already updated. Add this label once the docs are updated status/LGT1 One reviewer already commented LGTM type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GMHDBJD @csuzhangxc