This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
error_message: more friendly error message #711 #799
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMHDBJD
added
priority/normal
Minor change, requires approval from ≥1 primary reviewer
status/PTAL
This PR is ready for review. Add this label back after committing new changes
type/cherry-pick
This PR is just a cherry-pick (backport)
labels
Jul 10, 2020
Codecov Report
@@ Coverage Diff @@
## release-1.0 #799 +/- ##
===================================================
+ Coverage 57.2665% 57.8323% +0.5657%
===================================================
Files 161 167 +6
Lines 16741 16617 -124
===================================================
+ Hits 9587 9610 +23
+ Misses 6206 6132 -74
+ Partials 948 875 -73 |
LGTM |
@lance6716, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:tools(slack). |
lance6716
added
status/LGT1
One reviewer already commented LGTM
and removed
status/PTAL
This PR is ready for review. Add this label back after committing new changes
labels
Jul 10, 2020
please solve the conflicts |
WangXiangUSTC
approved these changes
Jul 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WangXiangUSTC
added
status/LGT2
Two reviewers already commented LGTM, ready for merge
and removed
status/LGT1
One reviewer already commented LGTM
labels
Jul 15, 2020
csuzhangxc
added
needs-update-docs
Should update docs after this PR is merged. Remove this label once the docs are updated
needs-update-release-note
This PR should be added into release notes. Remove this label once the release notes are updated
labels
Jul 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs-update-docs
Should update docs after this PR is merged. Remove this label once the docs are updated
needs-update-release-note
This PR should be added into release notes. Remove this label once the release notes are updated
priority/normal
Minor change, requires approval from ≥1 primary reviewer
status/LGT2
Two reviewers already commented LGTM, ready for merge
type/cherry-pick
This PR is just a cherry-pick (backport)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manually cherrypick #771
What problem does this PR solve?
What is changed and how it works?