Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

config, loader: auto-remove imported dump file (#770) #804

Merged
merged 2 commits into from
Jul 16, 2020
Merged

config, loader: auto-remove imported dump file (#770) #804

merged 2 commits into from
Jul 16, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

manually cherry-pick #770

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to update the documentation
  • Need to be included in the release note

@lance6716 lance6716 added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Jul 15, 2020
@codecov
Copy link

codecov bot commented Jul 15, 2020 •
edited
Loading

Codecov Report

Merging #804 into release-1.0 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release-1.0       #804   +/-   ##
==============================================
  Coverage      57.6876%   57.6876%           
==============================================
  Files              167        167           
  Lines            16676      16676           
==============================================
  Hits              9620       9620           
  Misses            6180       6180           
  Partials           876        876

GMHDBJD
GMHDBJD reviewed Jul 16, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jul 16, 2020
WangXiangUSTC
WangXiangUSTC approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jul 16, 2020
@lance6716 lance6716 merged commit 63e3388 into pingcap:release-1.0 Jul 16, 2020
@lance6716 lance6716 deleted the cp770 branch July 16, 2020 09:52
@lance6716 lance6716 added needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Jul 16, 2020
@lance6716 lance6716 mentioned this pull request Jul 21, 2020
Merged
2 tasks
@lance6716 lance6716 added already-update-docs The docs related to this PR already updated. Add this label once the docs are updated and removed needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Jul 21, 2020
@toutdesuite toutdesuite mentioned this pull request Jul 27, 2020
Merged
2 tasks
@ti-srebot ti-srebot mentioned this pull request Jul 27, 2020
Merged
2 tasks
@csuzhangxc
Copy link
Member

#1042 and #1145 may be needed to cherry-pick release-1.0.

@csuzhangxc csuzhangxc added this to the v1.0.7 milestone Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
already-update-docs The docs related to this PR already updated. Add this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v1.0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @csuzhangxc @WangXiangUSTC @GMHDBJD