Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

worker, utils: show same master status in one response (#817) #830

Merged
merged 2 commits into from
Jul 27, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

manually cherry-pick #817

What is changed and how it works?

when one response contains multiple relay and syncer status, use the larger master binlog position overwrite them and re-check status.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

@lance6716 lance6716 added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Jul 25, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jul 27, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC milestone Jul 27, 2020
@lance6716
Copy link
Collaborator Author

@WangXiangUSTC PTAL

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jul 27, 2020
@lance6716 lance6716 merged commit dc72ee8 into pingcap:master Jul 27, 2020
@lance6716 lance6716 deleted the cp817 branch July 27, 2020 05:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants