-
Notifications
You must be signed in to change notification settings - Fork 188
Conversation
dm/worker/config.go
Outdated
return nil | ||
|
||
_, err = c.DecryptPassword() | ||
return err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better return errors.Trace(err)
tests/_utils/restart_dm_worker
Outdated
|
||
echo "[$(date)] <<<<<< START DM-WORKER on port $port, config: $conf >>>>>>" | ||
cd $workdir | ||
$binary -test.coverprofile="$TEST_DIR/cov.$TEST_NAME.worker.$port.out" DEVEL \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems restart_dm_worker
has quite similar logic to run_dm_worker
script, is there any purpose to add this? In addition, the content of coverage file $TEST_DIR/cov.$TEST_NAME.worker.$port.out
will be truncated here, we'd better to use append stream to this file(>>
) or choose another file name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove mkdir
and ln
opeations, maybe we also add other operation in it later, how do you think about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mkdir -p
is reentrant, and we can also update ln
to [ -f $workdir/bin/mydumper ] || ln -s $PWD/bin/mydumper $workdir/bin/mydumper
to make it reentrant
Co-Authored-By: GregoryIan <ArGregoryIan@gmail.com>
Co-Authored-By: GregoryIan <ArGregoryIan@gmail.com>
…nto ian/restore-task
@csuzhangxc @amyangfei PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
What is changed and how it works?
store subtask in local disk of dm-worker.
In all request
start/stop/update task
, dm-worker would change meta firstly, then handle the request, we should explain it in document.And I would modify ansible and add integrate test later
Check List
Tests