Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

source: check whether GTID is ON in the upstream ealier (#946) #957

Merged
merged 2 commits into from
Aug 29, 2020

Conversation

ti-srebot
Copy link

cherry-pick #946 to release-2.0


What problem does this PR solve?

close #941

What is changed and how it works?

check whether GTID is ON in the upstream when operate-source create

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    run mysql with GTID_MODE=OFF, and set enable-gtid: true in source config

@ti-srebot ti-srebot added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Aug 29, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 merged commit 7f7a501 into pingcap:release-2.0 Aug 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants