This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
syncer: add metrics for sharding merge #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csuzhangxc
added
priority/normal
csuzhangxc
added
status/PTAL
|
@GregoryIan @amyangfei PTAL |
IANTHEREAL
reviewed
Apr 1, 2019
syncer/syncer.go
Outdated
| @@ -1574,6 +1574,8 @@ func (s *Syncer) Run(ctx context.Context) (err error) { | |||
| if err != nil { | |||
| return errors.Trace(err) | |||
| } | |||
| target, _ := GenTableID(ddlInfo.tableNames[1][0].Schema, ddlInfo.tableNames[1][0].Name) | |||
| unsyncedTableGauge.WithLabelValues(s.cfg.Name, target).Set(float64(remain)) | |||
There was a problem hiding this comment.
why not put it into L1582 scope? and I'm afraid two many table in this metric
There was a problem hiding this comment.
this scope can be reached only in sharding mode, see continue in L1542.
and we obtain remain in this scope.
There was a problem hiding this comment.
in order to handle CreateTableStmt in L1565, so we move it into L1582 scope?
There was a problem hiding this comment.
yep, and we also have non-shard table in shard mode
IANTHEREAL
reviewed
Apr 1, 2019
syncer/metrics.go
Outdated
| Namespace: "dm", | ||
| Subsystem: "syncer", | ||
| Name: "shard_lock_resolving", | ||
| Help: "waiting sharding DDL lock to be resolved", |
|
Rest LGTM |
|
/run-all-tests |
amyangfei
added
status/LGT1
|
LGTM |
IANTHEREAL
added
status/LGT2
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support to judge whether waiting for sharding DDL lock to be resolved through metrics.
What is changed and how it works?
Check List
Tests
dm_syncer_unsynced_table_number/dm_syncer_shard_lock_resolvingdm_syncer_unsynced_table_number/dm_syncer_shard_lock_resolvingdm_syncer_unsynced_table_number/dm_syncer_shard_lock_resolvingSide effects
Related changes
dm/dm-ansible