Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: warn the deprecated remove-meta in task config (#964) #965

Merged
merged 3 commits into from
Aug 31, 2020

Conversation

ti-srebot
Copy link

cherry-pick #964 to release-2.0


What problem does this PR solve?

close #935

What is changed and how it works?

detect remove-meta in task config but do nothing, except print logs and return message for start-task

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@ti-srebot ti-srebot added priority/unimportant Really minor change, requires approval from secondary reviewers type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Aug 31, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added the status/LGT1 One reviewer already commented LGTM label Aug 31, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.2 milestone Aug 31, 2020
@lance6716
Copy link
Collaborator

LGTM

@csuzhangxc
Copy link
Member

/run-all-tests.

ha case failed again.

@lance6716
Copy link
Collaborator

/run-all-tests.

ha case failed again.

previous ha fail, master-3 keeps printing log of stop task

@lance6716
Copy link
Collaborator

/run-all-tests

@lance6716 lance6716 merged commit d31ab59 into pingcap:release-2.0 Aug 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants