Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: change max_allowed_packet to 64MB #99

Merged
merged 2 commits into from
Apr 2, 2019

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

the default value of max_allowed_packet in MySQL server and go-sql-driver/mysql driver is 4MB, but in TiDB server it's 64MB.
ref:

What is changed and how it works?

we can refactor DB operation to a pkg and add test cases for config later.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • config with/without max_allowed_packet in DM-worker's config and task's config
    • hack the code to see the DSN

Side effects

  • Increased code complexity

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/enhancement Performance improvement or refactoring labels Apr 2, 2019
@IANTHEREAL
Copy link
Collaborator

LGTM

@IANTHEREAL IANTHEREAL added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Apr 2, 2019
@amyangfei amyangfei added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Apr 2, 2019
@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc csuzhangxc merged commit 6855ea4 into pingcap:master Apr 2, 2019
@csuzhangxc csuzhangxc deleted the max-allowed-packet branch April 2, 2019 12:41
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/enhancement Performance improvement or refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants