Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto-increment: update doc for the new implementation #11798

Merged
merged 13 commits into from
Nov 7, 2022
Merged

auto-increment: update doc for the new implementation #11798

merged 13 commits into from
Nov 7, 2022

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Oct 26, 2022 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 26, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 26, 2022
@Oreoxmt Oreoxmt requested review from Oreoxmt and removed request for TomShawn October 26, 2022 08:03
@Oreoxmt Oreoxmt self-assigned this Oct 26, 2022
@Oreoxmt Oreoxmt added the translation/doing This PR’s assignee is translating this PR. label Oct 26, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Oct 26, 2022
@Oreoxmt Oreoxmt added missing-translation-status This PR does not have translation status info. v6.4 This PR/issue applies to TiDB v6.4. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed missing-translation-status This PR does not have translation status info. labels Oct 26, 2022
Oreoxmt
Oreoxmt reviewed Oct 26, 2022
View reviewed changes
auto-increment.md Outdated Show resolved Hide resolved
auto-increment.md Outdated Show resolved Hide resolved
auto-increment.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt self-requested a review October 26, 2022 08:23
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Oct 26, 2022

DNM until pingcap/tidb#38449 is merged

lcwangchao
lcwangchao approved these changes Oct 26, 2022
View reviewed changes
auto-increment.md Outdated
> **注意：**
>
> 无论新版本或旧版本，`AUTO_ID_CACHE` 设置为 1 都表明 TiDB 不再缓存 ID，但是具体对应的实现方式不一样。
> 早期的版本设置 `AUTO_ID_CACHE` 为 1 之后性能非常差，因为每次分配 ID 都需要通过一个 TiKV 事务完成 `AUTO_INCREMENT` 值的持久化修改。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"性能非常差" 是不是可以改个说法，比如相比新版本性能相对较差之类的

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果有测试数据可以加一下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当下测试还没有搞完

tiancaiamao and others added 3 commits October 26, 2022 16:33
@tiancaiamao @Oreoxmt
Update auto-increment.md
fa1e9e0 
Co-authored-by: Aolin <aolinz@outlook.com>
@tiancaiamao @Oreoxmt
Update auto-increment.md
cb66805 
Co-authored-by: Aolin <aolinz@outlook.com>
@tiancaiamao @Oreoxmt
Update auto-increment.md
9ef2de7 
Co-authored-by: Aolin <aolinz@outlook.com>
Oreoxmt
Oreoxmt reviewed Oct 26, 2022
View reviewed changes
auto-increment.md Outdated Show resolved Hide resolved
auto-increment.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt self-requested a review October 26, 2022 08:43
tiancaiamao and others added 2 commits October 27, 2022 14:41
@tiancaiamao @Oreoxmt
Update auto-increment.md
0cb82dd 
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt
fix format
f151f2a
@shichun-0415 shichun-0415 self-requested a review October 27, 2022 08:03
shichun-0415
shichun-0415 approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

auto-increment.md Outdated Show resolved Hide resolved
auto-increment.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 27, 2022
@Oreoxmt @shichun-0415
Apply suggestions from code review
36016ec 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
Oreoxmt
Oreoxmt reviewed Oct 27, 2022
View reviewed changes
auto-increment.md Outdated Show resolved Hide resolved
@tiancaiamao @Oreoxmt
Update auto-increment.md
284aeb7 
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt Oreoxmt self-requested a review November 1, 2022 02:21
Oreoxmt
Oreoxmt approved these changes Nov 1, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 1, 2022
Oreoxmt
Oreoxmt reviewed Nov 1, 2022
View reviewed changes
auto-increment.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt mentioned this pull request Nov 2, 2022
Merged
14 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 2, 2022
benmaoer
benmaoer approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@benmaoer benmaoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Oreoxmt
Oreoxmt reviewed Nov 4, 2022
View reviewed changes
auto-increment.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2022
shichun-0415
shichun-0415 reviewed Nov 4, 2022
View reviewed changes
mysql-compatibility.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 5, 2022
tiancaiamao and others added 2 commits November 5, 2022 22:10
@tiancaiamao @shichun-0415
Update mysql-compatibility.md
81c79aa 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@Oreoxmt
Merge branch 'master' into autoid
0ce2aa3
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0ce2aa3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2022
@Oreoxmt Oreoxmt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022
@ti-chi-bot ti-chi-bot merged commit 0e3b91c into pingcap:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

@benmaoer benmaoer benmaoer approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.4 This PR/issue applies to TiDB v6.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tiancaiamao @ti-chi-bot @Oreoxmt @lcwangchao @benmaoer @shichun-0415