Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add descriptions for some system tables #15864

Merged
merged 5 commits into from
Dec 21, 2023
Merged

*: add descriptions for some system tables #15864

merged 5 commits into from
Dec 21, 2023

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Dec 21, 2023 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@wjhuang2016
done
dc66ed9 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 21, 2023
@hfxsd hfxsd self-assigned this Dec 21, 2023
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed missing-translation-status This PR does not have translation status info. labels Dec 21, 2023
@hfxsd hfxsd self-requested a review December 21, 2023 08:46
hfxsd
hfxsd reviewed Dec 21, 2023
View reviewed changes
mysql-schema.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Dec 21, 2023
View reviewed changes
mysql-schema.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Dec 21, 2023
View reviewed changes
mysql-schema.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 21, 2023
@hfxsd hfxsd changed the title add descriptions for some tables *: add descriptions for some system tables Dec 21, 2023
@hfxsd hfxsd mentioned this pull request Dec 21, 2023
Merged
18 tasks
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 21, 2023

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. ONCALL Relates to documentation oncall. and removed translation/doing This PR’s assignee is translating this PR. labels Dec 21, 2023
Benjamin2037
Benjamin2037 reviewed Dec 21, 2023
View reviewed changes
mysql-schema.md Outdated Show resolved Hide resolved
@hfxsd @Benjamin2037
Update mysql-schema.md
d3539c6 
Co-authored-by: Benjamin2037 <benjamin2037@sina.com>
Benjamin2037
Benjamin2037 reviewed Dec 21, 2023
View reviewed changes
mysql-schema.md Outdated Show resolved Hide resolved
@hfxsd hfxsd requested a review from Oreoxmt December 21, 2023 09:19
Oreoxmt
Oreoxmt approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

mysql-schema.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 21, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-21 09:00:37.196475997 +0000 UTC m=+1124328.233702912: ☑️ agreed by hfxsd.
  • 2023-12-21 09:24:44.097308782 +0000 UTC m=+1125775.134535709: ☑️ agreed by Oreoxmt.

@hfxsd @Oreoxmt @Benjamin2037
Apply suggestions from code review
6aa220e 
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Benjamin2037 <benjamin2037@sina.com>
Benjamin2037
Benjamin2037 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 21, 2023

@Benjamin2037: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd
Copy link
Collaborator

hfxsd commented Dec 21, 2023

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 21, 2023
@ti-chi-bot ti-chi-bot bot merged commit fda4e78 into pingcap:master Dec 21, 2023
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #15869.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 21, 2023
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 21, 2023
@ti-chi-bot
*: add descriptions for some system tables (#15864) (#15869)
30daabe
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 21, 2023
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@hfxsd hfxsd hfxsd approved these changes

@okJiang okJiang okJiang approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Assignees

@hfxsd hfxsd

Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wjhuang2016 @hfxsd @ti-chi-bot @Benjamin2037 @okJiang @Oreoxmt