Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource_control: add new privilege RESOURCE_GROUP_USER #17681

Merged
merged 15 commits into from
Jun 27, 2024
Merged

resource_control: add new privilege RESOURCE_GROUP_USER #17681

merged 15 commits into from
Jun 27, 2024

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Jun 13, 2024 •
edited by lilin90
Loading

What is changed, added or deleted? (Required)

  • Add new dynamic privilege RESOURCE_GROUP_USER
  • Add new system variable tidb_resource_control_strict_mode

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Jun 13, 2024
@glorv glorv requested review from nolouch and lilin90 June 13, 2024 10:37
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 13, 2024
@qiancai qiancai added v8.2 translation/doing This PR’s assignee is translating this PR. labels Jun 14, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 14, 2024
@qiancai qiancai added the area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. label Jun 14, 2024
lilin90
lilin90 reviewed Jun 17, 2024
View reviewed changes
optimizer-hints.md Outdated Show resolved Hide resolved
privilege-management.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-set-resource-group.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-set-resource-group.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
@lilin90 lilin90 requested a review from hfxsd June 17, 2024 03:08
glorv
glorv commented Jun 17, 2024
View reviewed changes
privilege-management.md Outdated Show resolved Hide resolved
glorv and others added 2 commits June 17, 2024 11:13
@glorv @lilin90
Apply suggestions from code review
3afcef2 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@glorv
reorder system-variables
a1e5313
lilin90
lilin90 reviewed Jun 17, 2024
View reviewed changes
optimizer-hints.md Outdated Show resolved Hide resolved
privilege-management.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-set-resource-group.md Outdated Show resolved Hide resolved
nolouch
nolouch reviewed Jun 17, 2024
View reviewed changes
optimizer-hints.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Jun 17, 2024
View reviewed changes
optimizer-hints.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-set-resource-group.md Outdated Show resolved Hide resolved
privilege-management.md Outdated Show resolved Hide resolved
nolouch
nolouch approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 17, 2024

@nolouch: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lilin90
lilin90 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 17, 2024
hfxsd
hfxsd reviewed Jun 19, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 19, 2024
@glorv @lilin90
Apply suggestions from code review
9c2a1ba 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@glorv glorv mentioned this pull request Jun 19, 2024
Merged
18 tasks
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 20, 2024
lilin90
lilin90 reviewed Jun 20, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@glorv @lilin90
Update system-variables.md
37a6e9a 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
hfxsd
hfxsd reviewed Jun 20, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 20, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-17 07:59:03.226994689 +0000 UTC m=+15269.712483521: ☑️ agreed by lilin90.
  • 2024-06-20 07:03:19.565532046 +0000 UTC m=+271126.051020878: ☑️ agreed by hfxsd.

@lilin90 @hfxsd
Update format
d50b7ad 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
lilin90
lilin90 reviewed Jun 27, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 544b9b2 into pingcap:master Jun 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@hfxsd hfxsd hfxsd approved these changes

@nolouch nolouch nolouch approved these changes

Assignees

@lilin90 lilin90

Labels
approved area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@glorv @nolouch @lilin90 @hfxsd @qiancai