Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove JSON_REPLACE from supported expressions for pushdown to TiKV #17714

Merged
merged 1 commit into from
Jun 18, 2024
Merged

remove JSON_REPLACE from supported expressions for pushdown to TiKV #17714

merged 1 commit into from
Jun 18, 2024

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Jun 18, 2024

What is changed, added or deleted? (Required)

TiDB v4.x and later versions do not support pushing down JSON_REPLACE to TiKV

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug. needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jun 18, 2024
@Oreoxmt Oreoxmt self-assigned this Jun 18, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2024
@Oreoxmt Oreoxmt mentioned this pull request Jun 18, 2024
Merged
17 tasks
@Oreoxmt Oreoxmt removed the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Jun 18, 2024
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Jun 18, 2024

/cc @joey-yez @windtalker

@ti-chi-bot ti-chi-bot bot requested review from joey-yez and windtalker June 18, 2024 03:58
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 18, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-18 05:53:55.294211628 +0000 UTC m=+94161.779700457: ☑️ agreed by hfxsd.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 18, 2024

@joey-yez: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

windtalker
windtalker approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 18, 2024

@windtalker: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt added the lgtm label Jun 18, 2024
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Jun 18, 2024

/approve

This was referenced Jun 18, 2024
Merged
Merged
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jun 18, 2024
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#17714
423bc9d 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #17726.

This was referenced Jun 18, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #17727.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jun 18, 2024
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#17714
2baeadd 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Jun 18, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #17728.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jun 18, 2024
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#17714
9aee9ef 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Jun 18, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #17729.

This was referenced Jun 18, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #17730.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 18, 2024
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jun 18, 2024
@ti-chi-bot
remove JSON_REPLACE from supported expressions for pushdown to TiKV (#…
1b76d84 
…17714) (#17729)
ti-chi-bot bot pushed a commit that referenced this pull request Jun 18, 2024
@ti-chi-bot
remove JSON_REPLACE from supported expressions for pushdown to TiKV (#…
89ab9aa 
…17714) (#17730)
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 18, 2024
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jun 18, 2024
@ti-chi-bot
remove JSON_REPLACE from supported expressions for pushdown to TiKV (#…
e5c4aeb 
…17714) (#17724)
ti-chi-bot bot pushed a commit that referenced this pull request Jun 18, 2024
@ti-chi-bot
remove JSON_REPLACE from supported expressions for pushdown to TiKV (#…
40808f7 
…17714) (#17725)
ti-chi-bot bot pushed a commit that referenced this pull request Jun 18, 2024
@ti-chi-bot
remove JSON_REPLACE from supported expressions for pushdown to TiKV (#…
49c44c7 
…17714) (#17727)
ti-chi-bot bot pushed a commit that referenced this pull request Jun 18, 2024
@ti-chi-bot
remove JSON_REPLACE from supported expressions for pushdown to TiKV (#…
4dffe3f 
…17714) (#17728)
ti-chi-bot bot pushed a commit that referenced this pull request Jun 18, 2024
@ti-chi-bot
remove JSON_REPLACE from supported expressions for pushdown to TiKV (#…
f7f7d4f 
…17714) (#17726)
ti-chi-bot bot pushed a commit that referenced this pull request Jun 18, 2024
@ti-chi-bot
remove JSON_REPLACE from supported expressions for pushdown to TiKV (#…
8b20c52 
…17714) (#17722)
ti-chi-bot bot pushed a commit that referenced this pull request Jun 18, 2024
@ti-chi-bot
remove JSON_REPLACE from supported expressions for pushdown to TiKV (#…
201568b 
…17714) (#17721)
ti-chi-bot bot pushed a commit that referenced this pull request Jun 18, 2024
@ti-chi-bot
remove JSON_REPLACE from supported expressions for pushdown to TiKV (#…
7f36eda 
…17714) (#17723)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joey-yez joey-yez joey-yez approved these changes

@hfxsd hfxsd hfxsd approved these changes

@windtalker windtalker windtalker approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Oreoxmt @ti-chi-bot @windtalker @hfxsd @joey-yez