Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.4: add APPLY, RECOMMEND, TIDB_CURRENT_TSO keywords #18820

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Oct 14, 2024

What is changed, added or deleted? (Required)

TiDB v8.4.0:

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. for-release This PR relates to a TiDB release but does not have a tracked feature. v8.4 This PR/issue applies to TiDB v8.4. labels Oct 14, 2024
@Oreoxmt Oreoxmt self-assigned this Oct 14, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2024
Copy link

ti-chi-bot bot commented Oct 15, 2024

@Defined2014: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Oct 21, 2024

/cc @fixdb

@ti-chi-bot ti-chi-bot bot requested a review from fixdb October 21, 2024 01:46
Copy link

ti-chi-bot bot commented Oct 21, 2024

@time-and-fate: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt requested a review from qiancai October 21, 2024 08:39
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 21, 2024
Copy link

ti-chi-bot bot commented Oct 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-21 09:56:02.288795785 +0000 UTC m=+258562.985586396: ☑️ agreed by qiancai.

@Oreoxmt Oreoxmt added the lgtm label Oct 22, 2024
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Oct 22, 2024

/approve
/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2024
Copy link

ti-chi-bot bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit 60d5555 into pingcap:master Oct 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.4 This PR/issue applies to TiDB v8.4.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants