Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SHARD_ROW_ID_BITS #3770

Merged
merged 13 commits into from
Jul 1, 2020
Merged

add SHARD_ROW_ID_BITS #3770

merged 13 commits into from
Jul 1, 2020

Conversation

kissmydb
Copy link
Contributor

@kissmydb kissmydb commented Jun 22, 2020 •
edited
Loading

SHARD_ROW_ID_BITS is lost in v4.0

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@kissmydb
add SHARD_ROW_ID_BITS
3624d54 
SHARD_ROW_ID_BITS is lost in v4.0
@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 22, 2020
@github-actions github-actions bot requested a review from TomShawn June 22, 2020 10:03
@kissmydb kissmydb requested a review from jackysp June 22, 2020 10:17
jackysp
jackysp reviewed Jun 22, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TomShawn
TomShawn reviewed Jun 22, 2020
View reviewed changes
shard_row_id_bits.md Outdated
@@ -0,0 +1,24 @@
---
title: SHARD_ROW_ID_BITS
category: reference
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summary 应该在 category 上面

TomShawn
TomShawn reviewed Jun 22, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请添加文档到 TOC。

shard_row_id_bits.md Outdated Show resolved Hide resolved
shard_row_id_bits.md Outdated Show resolved Hide resolved
shard_row_id_bits.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added needs-cherry-pick-4.0 size/medium Changes of a medium size. labels Jun 22, 2020
@ti-srebot
Copy link
Contributor

@jackysp, @TomShawn, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@jackysp, @TomShawn, PTAL.

@jackysp
Copy link
Member

jackysp commented Jun 27, 2020

Please address comments @kissmydb

@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Jun 27, 2020
@ti-srebot
Copy link
Contributor

@jackysp, @TomShawn, PTAL.

@ti-srebot
Copy link
Contributor

@kissmydb, please update your pull request.

yikeke
yikeke reviewed Jul 1, 2020
View reviewed changes
shard_row_id_bits.md Outdated Show resolved Hide resolved
kissmydb and others added 5 commits July 1, 2020 17:44
@kissmydb @TomShawn
Update shard_row_id_bits.md
5f10c89 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@kissmydb @TomShawn
Update shard_row_id_bits.md
3c67739 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@kissmydb
Update shard_row_id_bits.md
b167d86
@kissmydb
Update TOC.md
e8eb99c
rename
918288e
yikeke
yikeke reviewed Jul 1, 2020
View reviewed changes
shard-row-id-bits.md Outdated Show resolved Hide resolved
yikeke
yikeke reviewed Jul 1, 2020
View reviewed changes
faq/sql-faq.md Outdated Show resolved Hide resolved
yikeke
yikeke approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yikeke yikeke added translation/doing This PR’s assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 1, 2020
@yikeke yikeke self-assigned this Jul 1, 2020
yikeke
yikeke reviewed Jul 1, 2020
View reviewed changes
faq/sql-faq.md Show resolved Hide resolved
@yikeke
Copy link
Contributor

yikeke commented Jul 1, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 1, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 6d492e0 into master Jul 1, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 1, 2020
@kissmydb @ti-srebot
cherry pick pingcap#3770 to release-4.0
add9c55 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 1, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3848

ti-srebot added a commit that referenced this pull request Jul 1, 2020
@ti-srebot @kissmydb
add SHARD_ROW_ID_BITS (#3770) (#3848)
cd993ce 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: kissmydb <likun@pingcap.com>
yikeke pushed a commit to pingcap/docs that referenced this pull request Jul 10, 2020
align pingcap/docs-cn#3770
175c6cf
@yikeke yikeke mentioned this pull request Jul 10, 2020
Merged
5 tasks
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 10, 2020
yikeke added a commit to pingcap/docs that referenced this pull request Jul 14, 2020
@yikeke
Add shard-row-id-bits.md doc and fix some links (#3239)
2bc391f 
* align pingcap/docs-cn#3770

* remove SHARD_ROW_ID_BITS from tidb-specific-system-variables.md

* Update shard-row-id-bits.md

* remove SHARD_ROW_ID_BITS from alter table doc

* Update best-practices/high-concurrency-best-practices.md

* Update faq/tidb-faq.md

* add a missing alias
@ti-srebot ti-srebot mentioned this pull request Jul 14, 2020
Merged
5 tasks
@lilin90 lilin90 deleted the kissmydb-patch-3 branch August 5, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@yikeke yikeke yikeke approved these changes

@jackysp jackysp jackysp left review comments

Assignees

@yikeke yikeke

Labels
size/medium Changes of a medium size. status/can-merge Indicates a PR has been approved by a committer. status/require-change Needs the author to address comments. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kissmydb @ti-srebot @jackysp @yikeke @TomShawn