Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update some description about tidb-binlog and sync-diff-inspector #4040

Merged
merged 1 commit into from
Jul 24, 2020
Merged

tools: update some description about tidb-binlog and sync-diff-inspector #4040

merged 1 commit into from
Jul 24, 2020

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Jul 24, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

update some description about tidb-binlog and sync-diff-inspector

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

@TomShawn TomShawn added needs-cherry-pick-3.1 size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Jul 24, 2020
TomShawn
TomShawn approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@WangXiangUSTC Please involve a technical review.

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 24, 2020
@WangXiangUSTC
Copy link
Contributor Author

@csuzhangxc PTAL

csuzhangxc
csuzhangxc reviewed Jul 24, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 24, 2020
@TomShawn TomShawn merged commit ce8cb56 into pingcap:master Jul 24, 2020
@WangXiangUSTC WangXiangUSTC deleted the xiang/minor_update branch July 24, 2020 07:48
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 24, 2020
@WangXiangUSTC @ti-srebot
cherry pick pingcap#4040 to release-2.1
d31de0b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 24, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #4041

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 24, 2020
@WangXiangUSTC @ti-srebot
cherry pick pingcap#4040 to release-3.0
0e9578c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 24, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #4042

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 24, 2020
@WangXiangUSTC @ti-srebot
cherry pick pingcap#4040 to release-3.1
ac57e7c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 24, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #4043

TomShawn pushed a commit that referenced this pull request Jul 24, 2020
@ti-srebot @WangXiangUSTC
cherry pick #4040 to release-2.1 (#4041)
4aac676 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: WangXiangUSTC <wx347249478@gmail.com>
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 24, 2020
@WangXiangUSTC @ti-srebot
cherry pick pingcap#4040 to release-4.0
44e244f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 24, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4044

TomShawn pushed a commit that referenced this pull request Jul 24, 2020
@ti-srebot @WangXiangUSTC
cherry pick #4040 to release-3.0 (#4042)
ba57327 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: WangXiangUSTC <wx347249478@gmail.com>
TomShawn pushed a commit that referenced this pull request Jul 24, 2020
@ti-srebot @WangXiangUSTC
cherry pick #4040 to release-3.1 (#4043)
d1591bb 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: WangXiangUSTC <wx347249478@gmail.com>
ti-srebot added a commit that referenced this pull request Jul 24, 2020
@ti-srebot @WangXiangUSTC
tools: update some description about tidb-binlog and sync-diff-inspec…
625cf41 
…tor (#4040) (#4044)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: WangXiangUSTC <wx347249478@gmail.com>
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 13, 2020
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR’s assignee is translating this PR. label Aug 13, 2020
@Joyinqin Joyinqin mentioned this pull request Aug 13, 2020
Merged
9 tasks
This was referenced Aug 14, 2020
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees

@ireneontheway ireneontheway

@Joyinqin Joyinqin

Labels
size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@WangXiangUSTC @ti-srebot @Joyinqin @csuzhangxc @TomShawn @ireneontheway