Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiCDC: add trouble shooting info about DDL failures #5449

Merged
merged 15 commits into from
Mar 10, 2021
Merged

TiCDC: add trouble shooting info about DDL failures #5449

merged 15 commits into from
Mar 10, 2021

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Jan 29, 2021 •
edited by yikeke
Loading

What is changed, added or deleted? (Required)

Added information on how to handle DDL failures after 4.0.11

Which TiDB version(s) do your changes apply to? (Required)

4.0.11 or above，5.0.0-rc excluded.

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

https://github.com/pingcap/ticdc/pull/1291
https://github.com/pingcap/ticdc/pull/1352

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-srebot
Copy link
Contributor

This issue contains Chinese, please use English.

@TomShawn TomShawn self-assigned this Jan 29, 2021
@TomShawn TomShawn added needs-cherry-pick-4.0 size/medium Changes of a medium size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Jan 29, 2021
@liuzix @amyangfei
Update ticdc/troubleshoot-ticdc.md
a52727a 
Co-authored-by: amyangfei <amyangfei@gmail.com>
@ti-srebot
Copy link
Contributor

@TomShawn, @amyangfei, @leoppro, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@TomShawn, @amyangfei, @leoppro, PTAL.

@ti-srebot
Copy link
Contributor

@leoppro, PTAL.

@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Mar 1, 2021
@ti-srebot
Copy link
Contributor

@liuzix, please update your pull request.

amyangfei
amyangfei reviewed Mar 4, 2021
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 4, 2021
TomShawn
TomShawn reviewed Mar 4, 2021
View reviewed changes
ticdc/troubleshoot-ticdc.md Outdated Show resolved Hide resolved
ticdc/troubleshoot-ticdc.md Outdated Show resolved Hide resolved
ticdc/troubleshoot-ticdc.md Outdated Show resolved Hide resolved
ticdc/troubleshoot-ticdc.md Outdated Show resolved Hide resolved
ticdc/troubleshoot-ticdc.md Outdated Show resolved Hide resolved
@ti-srebot
Copy link
Contributor

@liuzix, please update your pull request.

@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 10, 2021
@TomShawn TomShawn merged commit ef8ef44 into pingcap:master Mar 10, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 10, 2021
@liuzix @ti-srebot
cherry pick pingcap#5449 to release-4.0
c5eddca 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 10, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5703

@TomShawn TomShawn added the requires-followup This PR requires a follow-up task after being merged. label Mar 10, 2021
@TomShawn
Copy link
Contributor

Follow-up: This PR needs to be cp to release-5.0 after TiDB 5.0 GA is released.

TomShawn added a commit that referenced this pull request Mar 10, 2021
@ti-srebot @liuzix @TomShawn
TiCDC: add trouble shooting info about DDL failures (#5449) (#5703)
e6e8bbc 
* cherry pick #5449 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update ticdc/troubleshoot-ticdc.md

Co-authored-by: Zixiong Liu <liuzixiong@pingcap.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn mentioned this pull request Mar 11, 2021
Merged
10 tasks
@TomShawn
Copy link
Contributor

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 11, 2021
@yikeke
Copy link
Contributor

yikeke commented Mar 17, 2021

You can cherry-pick it now and make it ready for merge on 5.0 branch. @TomShawn

@TomShawn
Copy link
Contributor

You can cherry-pick it now and make it ready for merge on 5.0 branch. @TomShawn

OK.

@TomShawn
Copy link
Contributor

/label needs-cherry-pick-5.0

@TomShawn
Copy link
Contributor

/remove-label follow-up

@ti-chi-bot ti-chi-bot removed the requires-followup This PR requires a follow-up task after being merged. label Mar 19, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 19, 2021
@liuzix @ti-srebot
cherry pick pingcap#5449 to release-5.0
50ed05d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 19, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5776

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/medium Changes of a medium size. labels Mar 19, 2021
ti-chi-bot pushed a commit that referenced this pull request Mar 24, 2021
@ti-srebot
TiCDC: add trouble shooting info about DDL failures (#5449) (#5776)
ed857f3
@ti-srebot ti-srebot mentioned this pull request Mar 24, 2021
Merged
10 tasks
ti-chi-bot pushed a commit that referenced this pull request Mar 24, 2021
@ti-srebot
TiCDC: add trouble shooting info about DDL failures (#5449) (#5776) (#…
e84adf6 
…5807)
This was referenced Mar 29, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@TomShawn TomShawn TomShawn approved these changes

@zier-one zier-one Awaiting requested review from zier-one

Assignees

@TomShawn TomShawn

Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liuzix @ti-srebot @TomShawn @yikeke @amyangfei @ti-chi-bot