Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kafka downstream example #6416

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Add kafka downstream example #6416

merged 2 commits into from
Jul 8, 2021

Conversation

chenmin1992
Copy link
Contributor

@chenmin1992 chenmin1992 commented Jun 8, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add kafka downstream example for convenience, and change the dirs of pumps to a better path that correspond to its default port.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Jun 8, 2021
@CLAassistant
Copy link

CLAassistant commented Jun 8, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 8, 2021 06:10
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jun 8, 2021

@chenmin1992 Could you please sign the CLA for this PR to be merged? Thanks

@TomShawn TomShawn requested a review from july2993 June 8, 2021 11:27
@TomShawn TomShawn added needs-cherry-pick-release-4.0 translation/doing This PR’s assignee is translating this PR. labels Jun 8, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 8, 2021
@ti-chi-bot
Copy link
Member

@july2993: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 7, 2021
@TomShawn TomShawn added type/enhancement The issue or PR belongs to an enhancement. require-LGT1 Indicates that the PR requires an LGTM. and removed needs-cherry-pick-release-4.0 labels Jul 7, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2636e54

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 7, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/rebase

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f5f4257

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@ti-chi-bot ti-chi-bot merged commit bd8d229 into pingcap:master Jul 8, 2021
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Jul 21, 2021
Merged
11 tasks
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 21, 2021
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@chenmin1992 @3AceShowHand
Add kafka downstream example (pingcap#6416)
f94260e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@july2993 july2993 july2993 approved these changes

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chenmin1992 @CLAassistant @TomShawn @ti-chi-bot @july2993 @Liuxiaozhen12