Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pr_template: Provides tips for cherry-pick #6702

Merged
merged 9 commits into from
Jul 23, 2021
Merged

pr_template: Provides tips for cherry-pick #6702

merged 9 commits into from
Jul 23, 2021

Conversation

TomShawn
Copy link
Contributor

What is changed, added or deleted? (Required)

pr_template: Provides tips for cherry-pick

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 19, 2021
@TomShawn TomShawn requested a review from qiancai July 19, 2021 11:11
@TomShawn TomShawn self-assigned this Jul 19, 2021
@TomShawn TomShawn added needs-cherry-pick-release-3.1 require-LGT1 Indicates that the PR requires an LGTM. translation/doing This PR’s assignee is translating this PR. labels Jul 19, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jul 19, 2021
qiancai
qiancai reviewed Jul 23, 2021
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomShawn PTAL

CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
@TomShawn @qiancai
Update CONTRIBUTING.md
e04a5bb 
Co-authored-by: Grace Cai <qqzczy@126.com>
qiancai
qiancai reviewed Jul 23, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
TomShawn and others added 2 commits July 23, 2021 13:46
qiancai
qiancai reviewed Jul 23, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@TomShawn @qiancai
Update CONTRIBUTING.md
0346770 
Co-authored-by: Grace Cai <qqzczy@126.com>
TomShawn
TomShawn commented Jul 23, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
qiancai
qiancai reviewed Jul 23, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Jul 23, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
qiancai
qiancai reviewed Jul 23, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@TomShawn @qiancai
Apply suggestions from code review
505e944 
Co-authored-by: Grace Cai <qqzczy@126.com>
@TomShawn TomShawn requested a review from qiancai July 23, 2021 08:02
@ti-chi-bot ti-chi-bot merged commit a6dbd7f into pingcap:master Jul 23, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 23, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6722.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6723.

This was referenced Jul 23, 2021
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6724.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 23, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6725.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 23, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6726.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 23, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6727.

@TomShawn TomShawn deleted the cherry-pick-guideline branch July 23, 2021 08:15
ti-chi-bot added a commit that referenced this pull request Jul 23, 2021
@ti-chi-bot
pr_template: Provides tips for cherry-pick (#6702) (#6724)
355b8c3
ti-chi-bot added a commit that referenced this pull request Jul 23, 2021
@ti-chi-bot
pr_template: Provides tips for cherry-pick (#6702) (#6723)
3078137
ti-chi-bot added a commit that referenced this pull request Jul 23, 2021
@ti-chi-bot
pr_template: Provides tips for cherry-pick (#6702) (#6722)
2cb60a9
ti-chi-bot added a commit that referenced this pull request Jul 23, 2021
@ti-chi-bot
pr_template: Provides tips for cherry-pick (#6702) (#6725)
2d83322
ti-chi-bot added a commit that referenced this pull request Jul 23, 2021
@ti-chi-bot
pr_template: Provides tips for cherry-pick (#6702) (#6726)
3fc7a11
ti-chi-bot added a commit that referenced this pull request Jul 23, 2021
@ti-chi-bot
pr_template: Provides tips for cherry-pick (#6702) (#6727)
f7f884b
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@TomShawn @3AceShowHand
pr_template: Provides tips for cherry-pick (pingcap#6702)
df6485e
@TomShawn TomShawn mentioned this pull request Jul 28, 2021
Merged
11 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 29, 2021
This was referenced Aug 5, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

Assignees

@TomShawn TomShawn

Labels
require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomShawn @ti-chi-bot @qiancai