Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql-compatibility: add doc for a UPDATE incompatibility case #7781

Merged
merged 6 commits into from
May 13, 2022
Merged

mysql-compatibility: add doc for a UPDATE incompatibility case #7781

merged 6 commits into from
May 13, 2022

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Dec 2, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

pingcap/tidb#25645

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2021
@tiancaiamao tiancaiamao mentioned this pull request Dec 2, 2021
Merged
14 tasks
@TomShawn TomShawn added needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. translation/from-docs This PR is translated from a PR in pingcap/docs. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. type/enhancement The issue or PR belongs to an enhancement. and removed missing-translation-status This PR does not have translation status info. labels Dec 3, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Dec 6, 2021

@tiancaiamao Please involve one or two tech reviewers. Thanks~

@TomShawn TomShawn added the status/PTAL This PR is ready for reviewing. label Dec 6, 2021
@tiancaiamao
Copy link
Contributor Author

@tiancaiamao Please involve one or two tech reviewers. Thanks~

OK, I'll address comment from @morgo and after I update the PR, I'll do it.

@morgo morgo requested review from morgo and removed request for morgo December 7, 2021 19:41
@TomShawn TomShawn added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Feb 11, 2022
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 11, 2022
This was referenced May 12, 2022
Merged
Merged
Merged
Merged
Merged
Merged
TomShawn
TomShawn approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2022
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 545c132

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2022
@ti-chi-bot ti-chi-bot merged commit 8babc61 into pingcap:master May 13, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9460.

@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9461.

@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9462.

@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9463.

@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9464.

@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9465.

@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9466.

ti-chi-bot added a commit that referenced this pull request May 13, 2022
@ti-chi-bot
mysql-compatibility: add doc for a UPDATE incompatibility case (#7781) (
6d3fea0 
#9460)
ti-chi-bot added a commit that referenced this pull request May 13, 2022
@ti-chi-bot
mysql-compatibility: add doc for a UPDATE incompatibility case (#7781) (
64f8f03 
#9462)
ti-chi-bot added a commit that referenced this pull request May 13, 2022
@ti-chi-bot
mysql-compatibility: add doc for a UPDATE incompatibility case (#7781) (
f4c8859 
#9463)
ti-chi-bot added a commit that referenced this pull request May 13, 2022
@ti-chi-bot
mysql-compatibility: add doc for a UPDATE incompatibility case (#7781) (
b850cc6 
#9461)
ti-chi-bot added a commit that referenced this pull request May 13, 2022
@ti-chi-bot
mysql-compatibility: add doc for a UPDATE incompatibility case (#7781) (
0884ed1 
#9464)
ti-chi-bot added a commit that referenced this pull request May 13, 2022
@ti-chi-bot
mysql-compatibility: add doc for a UPDATE incompatibility case (#7781) (
a7dfb85 
#9465)
ti-chi-bot added a commit that referenced this pull request May 13, 2022
@ti-chi-bot
mysql-compatibility: add doc for a UPDATE incompatibility case (#7781) (
22a9642 
#9466)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/from-docs This PR is translated from a PR in pingcap/docs. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiancaiamao @ti-chi-bot @TomShawn @shichun-0415