Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh: add clean-dump-file configuration (dev) #170

Merged
merged 1 commit into from
Jul 21, 2020
Merged

zh: add clean-dump-file configuration (dev) #170

merged 1 commit into from
Jul 21, 2020

Conversation

lance6716
Copy link
Contributor

What is changed, added or deleted? (Required)

add configuration introduced by pingcap/dm#770

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v2.0 changes for now)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

WangXiangUSTC
WangXiangUSTC reviewed Jul 21, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM， 之后发版需要说明下该配置在哪个版本引入的

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 21, 2020
@lance6716
Copy link
Contributor Author

@toutdesuite this PR is almost same with #169, PTAL

@toutdesuite toutdesuite added the translation/doing This PR’s assignee is translating this PR. label Jul 21, 2020
@toutdesuite toutdesuite self-assigned this Jul 21, 2020
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 21, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 21, 2020
@toutdesuite toutdesuite merged commit 5516067 into pingcap:master Jul 21, 2020
@lance6716 lance6716 deleted the patch-2 branch July 21, 2020 06:45
@toutdesuite toutdesuite added translation/done This PR has been translated. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 27, 2020
@toutdesuite toutdesuite mentioned this pull request Jul 27, 2020
Merged
2 tasks
@ti-srebot ti-srebot mentioned this pull request Jul 27, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangXiangUSTC WangXiangUSTC WangXiangUSTC left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@toutdesuite toutdesuite toutdesuite approved these changes

Assignees

@toutdesuite toutdesuite

Labels
status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @WangXiangUSTC @toutdesuite @ti-srebot