-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zh: modify format of --advertise-peer-urls
#320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @yikeke
master 分支也得提个 pr 改一下 @lance6716 文档这边一般的流程是先提 PR 到 master 分支,然后打 cherry-pick 的标签,可以方便地触发 bot 自动 cherry-pick 到你想要的 release 分支,FYI @lance6716 |
@@ -20,7 +20,7 @@ aliases: ['/docs-cn/tidb-data-migration/dev/command-line-flags/'] | |||
|
|||
- DM-master 节点间通信的外部连接地址 | |||
- 默认值为 `"{peer-urls}"` | |||
- 可选参数,可以为 `"域名:port"` 的形式 | |||
- 可选参数,可以为 `"http(s)://域名:port"` 的形式 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改动很小的话,英文版 en/command-line-flags.md 也帮忙一起改下? @lance6716
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我新开一个到master的,同时修改en
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,多谢
What is changed, added or deleted? (Required)
modify format of
--advertise-peer-urls
to align with pingcap/dm#955Which DM version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?