Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh: modify format of --advertise-peer-urls #320

Closed
wants to merge 1 commit into from

Conversation

lance6716
Copy link
Contributor

What is changed, added or deleted? (Required)

modify format of --advertise-peer-urls to align with pingcap/dm#955

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v3.0 changes)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts after cherry-picked

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2020
@ireneontheway ireneontheway self-requested a review August 31, 2020 07:22
@ireneontheway ireneontheway added needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. size/small Changes of a small size. labels Aug 31, 2020
@ireneontheway ireneontheway self-assigned this Aug 31, 2020
@ireneontheway ireneontheway added the translation/doing This PR’s assignee is translating this PR. label Aug 31, 2020
Copy link
Contributor

@ireneontheway ireneontheway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @yikeke

@yikeke
Copy link
Contributor

yikeke commented Aug 31, 2020

master 分支也得提个 pr 改一下 @lance6716

文档这边一般的流程是先提 PR 到 master 分支,然后打 cherry-pick 的标签,可以方便地触发 bot 自动 cherry-pick 到你想要的 release 分支,FYI @lance6716

@lance6716 lance6716 changed the base branch from release-2.0 to master August 31, 2020 07:49
@lance6716 lance6716 changed the base branch from master to release-2.0 August 31, 2020 07:49
@@ -20,7 +20,7 @@ aliases: ['/docs-cn/tidb-data-migration/dev/command-line-flags/']

- DM-master 节点间通信的外部连接地址
- 默认值为 `"{peer-urls}"`
- 可选参数,可以为 `"域名:port"` 的形式
- 可选参数,可以为 `"http(s)://域名:port"` 的形式
Copy link
Contributor

@yikeke yikeke Aug 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改动很小的话,英文版 en/command-line-flags.md 也帮忙一起改下? @lance6716

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我新开一个到master的,同时修改en

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,多谢

@lance6716 lance6716 closed this Aug 31, 2020
@yikeke yikeke added translation/no-need The changes in this PR don't need to be translated. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need The changes in this PR don't need to be translated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants