Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd/tls: add upgrade tls description #2612

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

pd/tls: add upgrade tls description #2612

wants to merge 8 commits into from
+87 −1

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Aug 23, 2024 •
edited by csuzhangxc
Loading

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign caitinchen for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 23, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2024

@lhy1024: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuSharp
add tls description
4ca2917 
Signed-off-by: husharp <ihusharp@gmail.com>
@HuSharp
add tls description
7ba4983 
Signed-off-by: husharp <ihusharp@gmail.com>
csuzhangxc
csuzhangxc reviewed Aug 23, 2024
View reviewed changes
zh/enable-tls-between-components.md Outdated Show resolved Hide resolved
zh/enable-tls-between-components.md Outdated Show resolved Hide resolved
zh/enable-tls-between-components.md Outdated Show resolved Hide resolved
zh/enable-tls-between-components.md Outdated Show resolved Hide resolved
zh/enable-tls-between-components.md Outdated Show resolved Hide resolved
csuzhangxc
csuzhangxc reviewed Aug 23, 2024
View reviewed changes
zh/enable-tls-between-components.md Outdated Show resolved Hide resolved
zh/enable-tls-between-components.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 23, 2024
@HuSharp
add tls description
54c18d0 
Signed-off-by: husharp <ihusharp@gmail.com>
@HuSharp
add patch
828ae52 
Signed-off-by: husharp <ihusharp@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 26, 2024
@HuSharp
add copy
09c31b0 
Signed-off-by: husharp <ihusharp@gmail.com>
csuzhangxc
csuzhangxc approved these changes Aug 26, 2024
View reviewed changes
zh/enable-tls-between-components.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 26, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-26 04:18:00.214657866 +0000 UTC m=+757475.349107987: ☑️ agreed by csuzhangxc.

@HuSharp @csuzhangxc
Update zh/enable-tls-between-components.md
8a42b76 
Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>
AndreMouche
AndreMouche approved these changes Aug 26, 2024
View reviewed changes
Copy link

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 26, 2024

@AndreMouche: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mayjiang0203
mayjiang0203 reviewed Sep 10, 2024
View reviewed changes
Copy link

@mayjiang0203 mayjiang0203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we add docs for how to disable tls in tls enabled cluster ?

@csuzhangxc
Copy link
Member

shall we add docs for how to disable tls in tls enabled cluster ?

We need to do more tests, it may not work. ref pingcap/tidb-operator#5728

@Oreoxmt Oreoxmt removed the request for review from qiancai November 6, 2024 06:19
@Oreoxmt Oreoxmt added needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. translation/doing This PR’s assignee is translating this PR. labels Nov 6, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 6, 2024
@Oreoxmt
revise wording and format
6b51c75 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 6, 2024

@HuSharp I've submitted a PR that revises the wording and structure of this document, PTAL HuSharp#1

@HuSharp
Merge pull request #1 from Oreoxmt/review-upgrade_pd_tls
5df78e5 
enable TLS: revise wording and format
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 6, 2024
@HuSharp
Copy link
Contributor Author

HuSharp commented Nov 6, 2024

@HuSharp I've submitted a PR that revises the wording and structure of this document, PTAL HuSharp#1

I have sent you my personal repository permissions invitation, feel free to change it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayjiang0203 mayjiang0203 mayjiang0203 left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@AndreMouche AndreMouche AndreMouche approved these changes

@lhy1024 lhy1024 Awaiting requested review from lhy1024

@Oreoxmt Oreoxmt Awaiting requested review from Oreoxmt

Assignees
No one assigned
Labels
needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@HuSharp @csuzhangxc @Oreoxmt @AndreMouche @mayjiang0203 @lhy1024