Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serivce account requirement for tiflash pod while restore #2651

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add serivce account requirement for tiflash pod while restore #2651

wants to merge 6 commits into from
+15 −1

Conversation

RidRisR
Copy link

@RidRisR RidRisR commented Nov 22, 2024 •
edited
Loading

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ti-chi-bot ti-chi-bot bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Nov 22, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lance6716 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Nov 22, 2024
@RidRisR RidRisR changed the title Add serivce account requirement for tiflash pod Add serivce account requirement for tiflash pod while restore Nov 22, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 22, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 22, 2024

@BornChanger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

RidRisR and others added 2 commits November 25, 2024 13:59
@RidRisR @csuzhangxc
Update zh/grant-permissions-to-remote-storage.md
e16811f 
Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>
@RidRisR @csuzhangxc
Update en/grant-permissions-to-remote-storage.md
1390411 
Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>
@csuzhangxc csuzhangxc requested a review from Oreoxmt November 25, 2024 06:05
@Oreoxmt Oreoxmt added needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Nov 25, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 25, 2024
Oreoxmt
Oreoxmt reviewed Nov 25, 2024
View reviewed changes
en/grant-permissions-to-remote-storage.md Outdated Show resolved Hide resolved
zh/grant-permissions-to-remote-storage.md Outdated Show resolved Hide resolved
RidRisR and others added 2 commits November 26, 2024 04:34
@RidRisR @Oreoxmt
Update en/grant-permissions-to-remote-storage.md
4b275a0 
Co-authored-by: Aolin <aolinz@outlook.com>
@RidRisR @Oreoxmt
Update zh/grant-permissions-to-remote-storage.md
f83980c 
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 26, 2024
@Oreoxmt Oreoxmt requested a review from csuzhangxc November 26, 2024 03:26
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 26, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-26 03:19:44.220917849 +0000 UTC m=+520171.840572365: ☑️ agreed by Oreoxmt.
  • 2024-11-26 06:44:53.062533235 +0000 UTC m=+532480.682187751: ☑️ agreed by csuzhangxc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BornChanger BornChanger BornChanger approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RidRisR @csuzhangxc @Oreoxmt @BornChanger