Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh: TiCDC TLS document #590

Merged
merged 7 commits into from
Jul 27, 2020
Merged

zh: TiCDC TLS document #590

merged 7 commits into from
Jul 27, 2020

Conversation

weekface
Copy link
Contributor

What is changed, added or deleted? (Required)

Don't merge before pingcap/tidb-operator#3010

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.1 (TiDB Operator 1.1 versions)
  • v1.0 (TiDB Operator 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@weekface weekface changed the title tls for ticdc zh: TiCDC TLS document Jul 24, 2020
@weekface weekface changed the title zh: TiCDC TLS document [DNM] zh: TiCDC TLS document Jul 24, 2020
@DanielZhangQD
Copy link
Contributor

/label needs-cherry-pick-1.1

@ti-srebot ti-srebot added the needs-cherry-pick-release-1.1 Should cherry pick this PR to release-1.1 branch. label Jul 24, 2020
@weekface weekface changed the title [DNM] zh: TiCDC TLS document zh: TiCDC TLS document Jul 27, 2020
DanielZhangQD
DanielZhangQD approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2020
@ran-huang ran-huang added the translation/doing This PR’s assignee is translating this PR. label Jul 27, 2020
@ran-huang ran-huang self-assigned this Jul 27, 2020
ran-huang
ran-huang reviewed Jul 27, 2020
View reviewed changes
zh/enable-tls-between-components.md Outdated Show resolved Hide resolved
zh/enable-tls-between-components.md Outdated Show resolved Hide resolved
zh/deploy-ticdc.md Outdated Show resolved Hide resolved
@weekface @ran-huang
Apply suggestions from code review
46ce2b5 
Co-authored-by: Ran <huangran@pingcap.com>
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 27, 2020
@ran-huang
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 27, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 591

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit a5ad350 into pingcap:master Jul 27, 2020
ti-srebot pushed a commit to ti-srebot/docs-tidb-operator that referenced this pull request Jul 27, 2020
@weekface @ti-srebot
cherry pick pingcap#590 to release-1.1
68f1bc6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 27, 2020
Merged
3 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #594

ran-huang pushed a commit that referenced this pull request Jul 27, 2020
@ti-srebot @weekface
cherry pick #590 to release-1.1 (#594)
1f9fdfa 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: weekface <weekface@gmail.com>
@ran-huang ran-huang mentioned this pull request Aug 5, 2020
Merged
7 tasks
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 5, 2020
@ti-srebot ti-srebot mentioned this pull request Aug 13, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

@ran-huang ran-huang ran-huang approved these changes

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

Assignees

@ran-huang ran-huang

Labels
needs-cherry-pick-release-1.1 Should cherry pick this PR to release-1.1 branch. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weekface @DanielZhangQD @ran-huang @ti-srebot