Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples for regexp functions #16962

Merged
merged 17 commits into from
Apr 15, 2024
Merged

Add examples for regexp functions #16962

merged 17 commits into from
Apr 15, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Apr 4, 2024

What is changed, added or deleted? (Required)

Closes #16943

Closes #16944

Closes #16945

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested review from Oreoxmt and qiancai April 4, 2024 10:50
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 4, 2024
mjonss
mjonss approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some curious questions :)

functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Show resolved Hide resolved
functions-and-operators/string-functions.md Show resolved Hide resolved
functions-and-operators/string-functions.md Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 4, 2024

@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM, with some curious questions :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dveeden @mjonss
Update functions-and-operators/string-functions.md
461a801 
Co-authored-by: Mattias Jonsson <mjonss@users.noreply.github.com>
@dveeden dveeden requested a review from lcwangchao April 5, 2024 06:33
@dveeden
Copy link
Contributor Author

dveeden commented Apr 5, 2024 •
edited
Loading

@Oreoxmt @qiancai Maybe we should consider to eventually move the Regular Expression Functions to a sub-page of the string functions. What do you think? Maybe we can do this after this PR has been merged.

@Oreoxmt Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR's assignee is translating this PR. needs-cherry-pick-release-8.0 labels Apr 7, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Apr 7, 2024
@Oreoxmt Oreoxmt added the area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. label Apr 7, 2024
@Oreoxmt Oreoxmt requested review from hfxsd and removed request for Oreoxmt and qiancai April 7, 2024 02:13
hfxsd
hfxsd reviewed Apr 7, 2024
View reviewed changes
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
@hfxsd hfxsd mentioned this pull request Apr 7, 2024
Merged
19 tasks
dveeden and others added 5 commits April 7, 2024 14:11
@dveeden @hfxsd
Update functions-and-operators/string-functions.md
63e6ff4 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@dveeden @hfxsd
Update functions-and-operators/string-functions.md
7fe7750 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@dveeden @hfxsd
Update functions-and-operators/string-functions.md
6ee6c9a 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@dveeden @hfxsd
Update functions-and-operators/string-functions.md
ef7a793 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@dveeden @hfxsd
Update functions-and-operators/string-functions.md
4eead08 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 8, 2024
@hfxsd hfxsd requested a review from Oreoxmt April 9, 2024 06:22
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-09 08:22:24.596361888 +0000 UTC m=+950606.123902435: ☑️ agreed by hfxsd.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 9, 2024
@hfxsd hfxsd added the lgtm label Apr 15, 2024
@hfxsd
Copy link
Collaborator

hfxsd commented Apr 15, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 15, 2024
@ti-chi-bot ti-chi-bot bot merged commit e570f96 into pingcap:master Apr 15, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17196.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 15, 2024
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Apr 15, 2024
@ti-chi-bot
Add examples for regexp functions (#16962) (#17196)
60ac849
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 26, 2024
Merged
19 tasks
dveeden added a commit to dveeden/docs that referenced this pull request May 15, 2024
@dveeden
Add examples for regexp functions (pingcap#16962)
e92a3b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjonss mjonss mjonss approved these changes

@hfxsd hfxsd hfxsd approved these changes

@lcwangchao lcwangchao Awaiting requested review from lcwangchao

@Oreoxmt Oreoxmt Awaiting requested review from Oreoxmt

Assignees

@hfxsd hfxsd

Labels
approved area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
5 participants
@dveeden @hfxsd @ti-chi-bot @mjonss @Oreoxmt