Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alert-rules: refine duplicate tidb binlog alerting rules docs #1721

Merged
merged 3 commits into from
Jan 7, 2020

Conversation

yikeke
Copy link
Contributor

@yikeke yikeke commented Dec 24, 2019

What is changed, added or deleted?

  1. remove duplicate content in reference/alert-rules.md
  2. refine descriptions according to the Chinese version in tidb-binlog/monitor.md

What is the related PR or file link(s)?

pingcap/docs-cn#1972

Which version does your change affect?

dev/3.1/3.0/2.1

@yikeke yikeke requested review from july2993 and removed request for WangXiangUSTC December 24, 2019 08:44
@yikeke yikeke added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Dec 24, 2019
@yikeke yikeke mentioned this pull request Dec 25, 2019
@WangXiangUSTC
Copy link
Contributor

LGTM

@yikeke yikeke removed the request for review from july2993 January 7, 2020 07:00
@yikeke
Copy link
Contributor Author

yikeke commented Jan 7, 2020

PTAL @lilin90

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit 0a27519 into pingcap:master Jan 7, 2020
@yikeke yikeke deleted the refine-tidb-binlog-alert-rules-doc branch June 10, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants