Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cyclic replication and configuration file in TiCDC deploy doc #3200

Merged
merged 5 commits into from
Jul 14, 2020
Merged

Add cyclic replication and configuration file in TiCDC deploy doc #3200

merged 5 commits into from
Jul 14, 2020

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jul 8, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

  • Add cyclic replication
  • Add task configuration file

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/large Changes of a large size. needs-cherry-pick-4.0 labels Jul 8, 2020
@TomShawn TomShawn added size/medium Changes of a medium size. size/large Changes of a large size. and removed size/large Changes of a large size. size/medium Changes of a medium size. labels Jul 8, 2020
@yikeke yikeke requested review from ran-huang and removed request for yikeke July 13, 2020 09:17
@yikeke
Copy link
Contributor

yikeke commented Jul 13, 2020

Please help review this PR, thanks~ @ran-huang

ran-huang
ran-huang reviewed Jul 13, 2020
View reviewed changes
ticdc/manage-ticdc.md Show resolved Hide resolved
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
TomShawn and others added 2 commits July 13, 2020 20:04
@TomShawn @ran-huang
Apply suggestions from code review
3818bff 
Co-authored-by: Ran <huangran@pingcap.com>
@TomShawn
align blank lines
b26bf18
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2020
@ran-huang
Copy link
Contributor

@amyangfei @overvenus PTAL, thanks~

@ti-srebot
Copy link
Contributor

@overvenus,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@ran-huang ran-huang merged commit 7d7037f into pingcap:master Jul 14, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 14, 2020
@TomShawn @ti-srebot
cherry pick pingcap#3200 to release-4.0
5b62777 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 14, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3268

@TomShawn TomShawn deleted the cyclic-replicai branch July 14, 2020 10:04
TomShawn added a commit that referenced this pull request Jul 14, 2020
@ti-srebot @TomShawn
cherry pick #3200 to release-4.0 (#3268)
17c3efb 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

@ran-huang ran-huang ran-huang approved these changes

@overvenus overvenus overvenus approved these changes

@amyangfei amyangfei Awaiting requested review from amyangfei

Assignees
No one assigned
Labels
size/large Changes of a large size. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomShawn @yikeke @ran-huang @ti-srebot @overvenus