Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tidb-specific-system-variables.md #3215

Merged
17 commits merged into from
Jul 10, 2020
Merged

Update tidb-specific-system-variables.md #3215

17 commits merged into from
Jul 10, 2020

Conversation

ireneontheway
Copy link
Contributor

What is changed, added or deleted? (Required)

Update tidb-specific-system-variables.md to include missing variables.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ireneontheway
Copy link
Contributor Author

/label needs-cherry-pick-4.0,translation/from-docs-cn

@ti-srebot ti-srebot added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 9, 2020
@ireneontheway
Copy link
Contributor Author

@yikeke Can you help me review the PR?

@yikeke yikeke requested review from yikeke and bobotu July 10, 2020 03:43
yikeke
yikeke reviewed Jul 10, 2020
View reviewed changes
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
@yikeke yikeke added the status/require-change Needs the author to address comments. label Jul 10, 2020
yikeke
yikeke reviewed Jul 10, 2020
View reviewed changes
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
@yikeke yikeke requested a review from a user July 10, 2020 04:41
@yikeke yikeke mentioned this pull request Jul 10, 2020
Closed
22 tasks
@ghost
Copy link

ghost commented Jul 10, 2020

The dead anchor check was failing because SHARD_ROW_ID_BITS had been removed. I've added it back in for now. It's wrong, but I will fix it in #3152 after this PR merges.

LGTM

@ti-srebot
Copy link
Contributor

@nullnotnil, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@ghost ghost merged commit e7bf6e2 into pingcap:master Jul 10, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 10, 2020
@ireneontheway @ti-srebot
cherry pick pingcap#3215 to release-4.0
77f00ac 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 10, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3237

ghost pushed a commit that referenced this pull request Jul 10, 2020
@ti-srebot @ireneontheway
cherry pick #3215 to release-4.0 (#3237)
46ba59f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
@ghost ghost mentioned this pull request Jul 10, 2020
Merged
5 tasks
@yikeke yikeke mentioned this pull request Jul 10, 2020
Merged
5 tasks
@yikeke
Copy link
Contributor

yikeke commented Jul 10, 2020

The dead anchor check was failing because SHARD_ROW_ID_BITS had been removed. I've added it back in for now. It's wrong, but I will fix it in #3152 after this PR merges.

LGTM

The SHARD_ROW_ID_BITS doc is added back in dev/v4.0 in #3239. Please merge #3239 first before we merge #3152. @nullnotnil

@ti-srebot ti-srebot mentioned this pull request Jul 14, 2020
Merged
5 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke left review comments

@bobotu bobotu Awaiting requested review from bobotu

Assignees
No one assigned
Labels
status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ireneontheway @ti-srebot @yikeke