Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo in sql-statement-split-region.md #4435

Merged
merged 2 commits into from
Dec 21, 2020
Merged

Fix a typo in sql-statement-split-region.md #4435

merged 2 commits into from
Dec 21, 2020

Conversation

killua525
Copy link
Contributor

@killua525 killua525 commented Dec 17, 2020 •
edited by TomShawn
Loading

split table|index BY

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Dec 17, 2020
@CLAassistant
Copy link

CLAassistant commented Dec 17, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@TomShawn
Copy link
Contributor

@killua525 Thanks for your contribution! Could you please sign the CLA for this PR to be merged?

TomShawn
TomShawn approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 21, 2020
@TomShawn TomShawn added needs-cherry-pick-3.0 needs-cherry-pick-master Should cherry pick this PR to master branch. translation/no-need No need to translate this PR. labels Dec 21, 2020
@TomShawn TomShawn merged commit 1dbd15f into pingcap:release-4.0 Dec 21, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Dec 21, 2020
@killua525 @ti-srebot
cherry pick pingcap#4435 to release-3.0
3f050d4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 21, 2020
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #4445

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Dec 21, 2020
@killua525 @ti-srebot
cherry pick pingcap#4435 to release-3.1
9ad9b0e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 21, 2020
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #4446

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Dec 21, 2020
@killua525 @ti-srebot
cherry pick pingcap#4435 to master
ac033d6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 21, 2020
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to master in PR #4447

TomShawn pushed a commit that referenced this pull request Dec 21, 2020
@ti-srebot @killua525
cherry pick #4435 to release-3.0 (#4445)
e41ef62 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: killua525 <19486826+killua525@users.noreply.github.com>
TomShawn pushed a commit that referenced this pull request Dec 21, 2020
@ti-srebot @killua525
cherry pick #4435 to release-3.1 (#4446)
c02917d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: killua525 <19486826+killua525@users.noreply.github.com>
@TomShawn TomShawn changed the title Update sql-statement-split-region.md Fix a typo in sql-statement-split-region.md Dec 21, 2020
TomShawn pushed a commit that referenced this pull request Dec 21, 2020
@ti-srebot @killua525
cherry pick #4435 to master (#4447)
3f658ac 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: killua525 <19486826+killua525@users.noreply.github.com>
@killua525 killua525 deleted the patch-1 branch December 23, 2020 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-master Should cherry pick this PR to master branch. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@killua525 @CLAassistant @TomShawn @ti-srebot