planner: add docs for some variables #9943

qw4990 · 2022-08-11T11:15:10Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2022-08-11T11:15:11Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Oreoxmt
TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

TomShawn · 2022-08-11T11:20:29Z

/cc @songrijie

system-variables.md

songrijie · 2022-08-12T06:02:41Z

Others LGTM

system-variables.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

system-variables.md

Co-authored-by: Aolin <aolinz@outlook.com>

TomShawn · 2022-08-18T07:20:32Z

/merge

ti-chi-bot · 2022-08-18T07:20:35Z

This pull request has been accepted and is ready to merge.

Commit hash: 676a458

ti-chi-bot · 2022-08-18T07:37:30Z

In response to a cherrypick label: new pull request created: #10054.

ti-chi-bot · 2022-10-09T02:11:56Z

In response to a cherrypick label: new pull request created: #10668.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

TomShawn · 2022-10-12T09:46:53Z

system-variables.md

@@ -1724,6 +1764,35 @@ For a system upgraded to v5.0 from an earlier version, if you have not modified
 - This variable is used to set whether the optimizer executes the optimization operation of pushing down the aggregate function to the position before Join, Projection, and UnionAll.
 - When the aggregate operation is slow in query, you can set the variable value to ON.

+### tidb_opt_cartesian_bcj


Incorrect variable name. Fixed in #10782

TomShawn · 2022-10-12T09:47:20Z

system-variables.md

+- Default value: `3.0`
+- Indicates the CPU cost of starting a Golang goroutine in TiDB. This variable is internally used in the [Cost Model](/cost-model.md), and it is **NOT** recommended to modify its value.
+
+### tidb_opt_cop_cpu_factor


Incorrect variable name. Fixed in #10782

TomShawn · 2022-10-12T09:47:32Z

system-variables.md

+- Default value: `3.0`
+- Indicates the CPU cost for TiDB to process one row. This variable is internally used in the [Cost Model](/cost-model.md), and it is **NOT** recommended to modify its value.
+
+### tidb_opt_desc_scan_factor


Incorrect variable name. Fixed in #10782

TomShawn · 2022-10-12T09:48:38Z

system-variables.md

@@ -1833,6 +1938,15 @@ mysql> desc select count(distinct a) from test.t;
 - Default value: `ON`


Incorrect default value. Fixed in #10782.

qw4990 added 5 commits August 3, 2022 11:14

fix ci

73c22dc

fixup

d700942

Merge remote-tracking branch 'upstream/master' into vars

cbcc7ca

fixup

ea8e1c2

fixup

aa8d832

ti-chi-bot requested a review from shichun-0415 August 11, 2022 11:15

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 11, 2022

TomShawn self-assigned this Aug 11, 2022

TomShawn added area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. add-missing-docs Add missing system variables to documentation and removed missing-translation-status This PR does not have translation status info. labels Aug 11, 2022

TomShawn self-requested a review August 11, 2022 11:16

TomShawn added the translation/doing This PR's assignee is translating this PR. label Aug 11, 2022

ti-chi-bot requested a review from songrijie August 11, 2022 11:20

songrijie reviewed Aug 12, 2022

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

songrijie reviewed Aug 12, 2022

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

TomShawn added the needs-cherry-pick-release-6.2 label Aug 15, 2022

TomShawn requested a review from chrysan August 15, 2022 08:33

address comments

b8aab3e

chrysan approved these changes Aug 15, 2022

View reviewed changes

TomShawn reviewed Aug 16, 2022

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

TomShawn reviewed Aug 16, 2022

View reviewed changes

qw4990 and others added 4 commits August 16, 2022 15:23

Update system-variables.md

ab89763

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update system-variables.md

b77e6c2

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update system-variables.md

fe0b085

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update system-variables.md

a39e5d6

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 18, 2022

TomShawn reviewed Aug 18, 2022

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

TomShawn reviewed Aug 18, 2022

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

TomShawn reviewed Aug 18, 2022

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

TomShawn reviewed Aug 18, 2022

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

TomShawn reviewed Aug 18, 2022

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

TomShawn reviewed Aug 18, 2022

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

TomShawn reviewed Aug 18, 2022

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

Apply suggestions from code review

676a458

Co-authored-by: Aolin <aolinz@outlook.com>

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 18, 2022

ti-chi-bot mentioned this pull request Aug 18, 2022

sysvar: add 12 missing planner sysvars (#10940) pingcap/docs-cn#10977

Merged

12 tasks

ti-chi-bot merged commit 44108aa into pingcap:master Aug 18, 2022

ti-chi-bot mentioned this pull request Aug 18, 2022

planner: add docs for some variables (#9943) #10054

Merged

13 tasks

ti-chi-bot added a commit that referenced this pull request Aug 18, 2022

planner: add docs for some variables (#9943) (#10054)

1a3c063

TomShawn added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Oct 9, 2022

ti-chi-bot mentioned this pull request Oct 9, 2022

planner: add docs for some variables (#9943) #10668

Merged

13 tasks

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 9, 2022

This is an automated cherry-pick of pingcap#9943

b3bc95b

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

TomShawn pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 9, 2022

This is an automated cherry-pick of pingcap#9943

05035d6

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot added a commit that referenced this pull request Oct 12, 2022

planner: add docs for some variables (#9943) (#10668)

0df907d

TomShawn reviewed Oct 12, 2022

View reviewed changes

ti-chi-bot mentioned this pull request Oct 14, 2022

sysvar: add 12 missing planner sysvars (#10940) pingcap/docs-cn#11630

Merged

12 tasks

shichun-0415 mentioned this pull request Feb 2, 2023

Document missing system variables #3155

Closed

22 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

planner: add docs for some variables #9943

planner: add docs for some variables #9943

qw4990 commented Aug 11, 2022 •

edited by shichun-0415

Loading

ti-chi-bot commented Aug 11, 2022 •

edited

Loading

TomShawn commented Aug 11, 2022

songrijie commented Aug 12, 2022

TomShawn commented Aug 18, 2022

ti-chi-bot commented Aug 18, 2022

ti-chi-bot commented Aug 18, 2022

ti-chi-bot commented Oct 9, 2022

TomShawn Oct 12, 2022

TomShawn Oct 12, 2022

TomShawn Oct 12, 2022

TomShawn Oct 12, 2022

		@@ -1833,6 +1938,15 @@ mysql> desc select count(distinct a) from test.t;
		- Default value: `ON`

planner: add docs for some variables #9943

planner: add docs for some variables #9943

Conversation

qw4990 commented Aug 11, 2022 • edited by shichun-0415 Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

ti-chi-bot commented Aug 11, 2022 • edited Loading

TomShawn commented Aug 11, 2022

songrijie commented Aug 12, 2022

TomShawn commented Aug 18, 2022

ti-chi-bot commented Aug 18, 2022

ti-chi-bot commented Aug 18, 2022

ti-chi-bot commented Oct 9, 2022

TomShawn Oct 12, 2022

Choose a reason for hiding this comment

TomShawn Oct 12, 2022

Choose a reason for hiding this comment

TomShawn Oct 12, 2022

Choose a reason for hiding this comment

TomShawn Oct 12, 2022

Choose a reason for hiding this comment

qw4990 commented Aug 11, 2022 •

edited by shichun-0415

Loading

ti-chi-bot commented Aug 11, 2022 •

edited

Loading