This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
fix scan null string error #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
reviewed
Sep 9, 2020
| mock.ExpectQuery("SELECT @@default_master_connection").WillReturnError(fmt.Errorf("mock error")) | ||
| mock.ExpectQuery("SHOW SLAVE STATUS").WillReturnRows(sqlmock.NewRows([]string{"SQL_Remaining_Delay"}).AddRow(nil)) | ||
|
|
||
| testFilePath := "/test" |
There was a problem hiding this comment.
maybe c.MkDir or something in /tmp
There was a problem hiding this comment.
It won't write file to disk since we don't use writeGlobalMetaData. So I think it's okay.
|
LGTM |
kennytm
approved these changes
Sep 9, 2020
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
tisonkun
pushed a commit
to tisonkun/tidb
that referenced
this pull request
Oct 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Dumpling use
[]stringto parse metadata variables, which can't handle null variable.What is changed and how it works?
Use
[]sql.NullStringinstead of[]string.Check List
Tests
Related changes
Release note